* [PATCH] sub-process: fix comment about api-sub-process.txt
@ 2017-06-14 15:12 Christian Couder
2017-06-14 18:26 ` Jonathan Nieder
0 siblings, 1 reply; 4+ messages in thread
From: Christian Couder @ 2017-06-14 15:12 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Ben Peart, Christian Couder
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
sub-process.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sub-process.h b/sub-process.h
index 7d451e1cde..d9a45cd359 100644
--- a/sub-process.h
+++ b/sub-process.h
@@ -7,7 +7,7 @@
/*
* Generic implementation of background process infrastructure.
- * See Documentation/technical/api-background-process.txt.
+ * See: Documentation/technical/api-sub-process.txt
*/
/* data structures */
--
2.13.1.453.g04e95ab038
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sub-process: fix comment about api-sub-process.txt
2017-06-14 15:12 [PATCH] sub-process: fix comment about api-sub-process.txt Christian Couder
@ 2017-06-14 18:26 ` Jonathan Nieder
2017-06-15 14:10 ` Ben Peart
2017-06-15 21:34 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Nieder @ 2017-06-14 18:26 UTC (permalink / raw)
To: Christian Couder; +Cc: git, Junio C Hamano, Ben Peart, Christian Couder
Christian Couder wrote:
> Subject: sub-process: fix comment about api-sub-process.txt
nit: this one-line description doesn't describe what was wrong and is
being fixed. I think something like
sub-process: correct path to API docs in comment
would be easier to understand in "git log" output.
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> sub-process.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
With or without such a tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> diff --git a/sub-process.h b/sub-process.h
> index 7d451e1cde..d9a45cd359 100644
> --- a/sub-process.h
> +++ b/sub-process.h
> @@ -7,7 +7,7 @@
>
> /*
> * Generic implementation of background process infrastructure.
> - * See Documentation/technical/api-background-process.txt.
> + * See: Documentation/technical/api-sub-process.txt
> */
>
> /* data structures */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sub-process: fix comment about api-sub-process.txt
2017-06-14 18:26 ` Jonathan Nieder
@ 2017-06-15 14:10 ` Ben Peart
2017-06-15 21:34 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Ben Peart @ 2017-06-15 14:10 UTC (permalink / raw)
To: Jonathan Nieder, Christian Couder; +Cc: git, Junio C Hamano, Christian Couder
On 6/14/2017 2:26 PM, Jonathan Nieder wrote:
> Christian Couder wrote:
>
>> Subject: sub-process: fix comment about api-sub-process.txt
>
> nit: this one-line description doesn't describe what was wrong and is
> being fixed. I think something like
>
> sub-process: correct path to API docs in comment
Looks good to me. Thanks for finding/fixing this.
>
> would be easier to understand in "git log" output.
>
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>> ---
>> sub-process.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> With or without such a tweak,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
>> diff --git a/sub-process.h b/sub-process.h
>> index 7d451e1cde..d9a45cd359 100644
>> --- a/sub-process.h
>> +++ b/sub-process.h
>> @@ -7,7 +7,7 @@
>>
>> /*
>> * Generic implementation of background process infrastructure.
>> - * See Documentation/technical/api-background-process.txt.
>> + * See: Documentation/technical/api-sub-process.txt
>> */
>>
>> /* data structures */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sub-process: fix comment about api-sub-process.txt
2017-06-14 18:26 ` Jonathan Nieder
2017-06-15 14:10 ` Ben Peart
@ 2017-06-15 21:34 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2017-06-15 21:34 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Christian Couder, git, Ben Peart, Christian Couder
Jonathan Nieder <jrnieder@gmail.com> writes:
> Christian Couder wrote:
>
>> Subject: sub-process: fix comment about api-sub-process.txt
>
> nit: this one-line description doesn't describe what was wrong and is
> being fixed. I think something like
>
> sub-process: correct path to API docs in comment
>
> would be easier to understand in "git log" output.
Indeed. Thanks.
>
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>> ---
>> sub-process.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> With or without such a tweak,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
>> diff --git a/sub-process.h b/sub-process.h
>> index 7d451e1cde..d9a45cd359 100644
>> --- a/sub-process.h
>> +++ b/sub-process.h
>> @@ -7,7 +7,7 @@
>>
>> /*
>> * Generic implementation of background process infrastructure.
>> - * See Documentation/technical/api-background-process.txt.
>> + * See: Documentation/technical/api-sub-process.txt
>> */
>>
>> /* data structures */
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-15 21:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-14 15:12 [PATCH] sub-process: fix comment about api-sub-process.txt Christian Couder
2017-06-14 18:26 ` Jonathan Nieder
2017-06-15 14:10 ` Ben Peart
2017-06-15 21:34 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).