git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Ben Peart <peartben@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] sub-process: fix comment about api-sub-process.txt
Date: Wed, 14 Jun 2017 11:26:07 -0700	[thread overview]
Message-ID: <20170614182607.GW133952@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170614151225.31055-1-chriscool@tuxfamily.org>

Christian Couder wrote:

> Subject: sub-process: fix comment about api-sub-process.txt

nit: this one-line description doesn't describe what was wrong and is
being fixed.  I think something like

	sub-process: correct path to API docs in comment

would be easier to understand in "git log" output.

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  sub-process.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

With or without such a tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

> diff --git a/sub-process.h b/sub-process.h
> index 7d451e1cde..d9a45cd359 100644
> --- a/sub-process.h
> +++ b/sub-process.h
> @@ -7,7 +7,7 @@
>  
>  /*
>   * Generic implementation of background process infrastructure.
> - * See Documentation/technical/api-background-process.txt.
> + * See: Documentation/technical/api-sub-process.txt
>   */
>  
>   /* data structures */

  reply	other threads:[~2017-06-14 18:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-14 15:12 [PATCH] sub-process: fix comment about api-sub-process.txt Christian Couder
2017-06-14 18:26 ` Jonathan Nieder [this message]
2017-06-15 14:10   ` Ben Peart
2017-06-15 21:34   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614182607.GW133952@aiede.mtv.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peartben@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).