From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag
Date: Fri, 02 Jul 2021 19:41:36 -0500 [thread overview]
Message-ID: <60dfb240ec471_3dd220879@natae.notmuch> (raw)
In-Reply-To: <87tulecfx7.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Wed, Jun 30 2021, Felipe Contreras wrote:
> > Ævar Arnfjörð Bjarmason wrote:
>
> >> Even if you don't care about the end result or making git easier to hack
> >> on for people who don't share your setup,
> >
> > I don't know about Junio, I do want to make git easier to hack for
> > people that don't share my setup, but I would like to know what that
> > setup is.
>
> I think all of this is covered in detail upthread.
From [1] I understand some systems have a problem clobbering a binary
that is being run. So if you are running a test that is using a binary
that you are rebuilding at the same time, you get an error.
OK.
I still don't see why anyone would want to rebuild the binary in the
middle of running tests. The result of the tests is only meaningful for
a particular build. This is what I don't get. I get that you want to do
this, what I don't get is *why*.
In order to be able to rebuild _and_ keep running the tests for a
certain build an out-of-source build is needed. Modern build systems
like CMake and Meson do these kinds of builds by default. In fact, Meson
doesn't support anything else.
With an in-source build such as in git, I first stop the tests, and
then rebuild, and that's what I would expect everyone else to do. I
don't think it has been explained why anybody wouldn't.
Cheers.
[1] https://lore.kernel.org/git/871r8r1hwe.fsf@evledraar.gmail.com/
--
Felipe Contreras
next prev parent reply other threads:[~2021-07-03 0:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:13 [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag Ævar Arnfjörð Bjarmason
2021-06-22 15:27 ` Taylor Blau
2021-06-22 17:34 ` Ævar Arnfjörð Bjarmason
2021-06-22 19:17 ` Jeff King
2021-06-23 19:54 ` Ævar Arnfjörð Bjarmason
2021-06-23 22:21 ` Jeff King
2021-06-24 13:53 ` Ævar Arnfjörð Bjarmason
2021-06-24 14:49 ` Jeff King
2021-06-25 9:49 ` Ævar Arnfjörð Bjarmason
2021-06-29 2:26 ` Jeff King
2021-06-29 6:19 ` Junio C Hamano
2021-06-29 7:39 ` Ævar Arnfjörð Bjarmason
2021-06-29 21:38 ` Junio C Hamano
2021-06-30 2:23 ` Jeff King
2021-07-01 3:54 ` Felipe Contreras
2021-07-01 13:34 ` Ævar Arnfjörð Bjarmason
2021-07-03 0:41 ` Felipe Contreras [this message]
2021-07-03 12:31 ` Ævar Arnfjörð Bjarmason
2021-07-03 18:42 ` Felipe Contreras
2021-06-23 19:15 ` Felipe Contreras
2021-06-23 19:09 ` Felipe Contreras
2021-06-23 19:01 ` Felipe Contreras
2021-06-23 19:45 ` Ævar Arnfjörð Bjarmason
2021-06-23 20:32 ` Felipe Contreras
2021-06-29 7:29 ` Ævar Arnfjörð Bjarmason
2021-07-01 3:06 ` Felipe Contreras
2021-06-23 19:21 ` Felipe Contreras
2021-06-23 19:59 ` Ævar Arnfjörð Bjarmason
2021-06-23 20:52 ` Felipe Contreras
2021-06-29 8:17 ` Ævar Arnfjörð Bjarmason
2021-07-01 3:19 ` Felipe Contreras
2021-06-29 8:44 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-08-18 21:36 ` [PATCH] Makefile: remove archives before manipulating them with 'ar' SZEDER Gábor
2021-08-19 23:39 ` Junio C Hamano
2021-09-01 17:06 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60dfb240ec471_3dd220879@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).