From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag
Date: Tue, 29 Jun 2021 10:17:43 +0200 [thread overview]
Message-ID: <8735t1gk0d.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <60d39ef9a8071_429020896@natae.notmuch>
On Wed, Jun 23 2021, Felipe Contreras wrote:
> Ævar Arnfjörð Bjarmason wrote:
>>
>> On Wed, Jun 23 2021, Felipe Contreras wrote:
>>
>> > Ævar Arnfjörð Bjarmason wrote:
>> >> @@ -2243,7 +2253,6 @@ SCRIPT_DEFINES = $(SHELL_PATH_SQ):$(DIFF_SQ):$(GIT_VERSION):\
>> >> $(gitwebdir_SQ):$(PERL_PATH_SQ):$(SANE_TEXT_GREP):$(PAGER_ENV):\
>> >> $(perllibdir_SQ)
>> >> define cmd_munge_script
>> >> -$(RM) $@ $@+ && \
>> >> sed -e '1s|#!.*/sh|#!$(SHELL_PATH_SQ)|' \
>> >> -e 's|@SHELL_PATH@|$(SHELL_PATH_SQ)|' \
>> >> -e 's|@@DIFF@@|$(DIFF_SQ)|' \
>> >
>> > Any reason why the same isn't done for the $(BUILT_INS) target?
>> >
>> >> @@ -2514,7 +2522,6 @@ endif
>> >> ifeq ($(GENERATE_COMPILATION_DATABASE),yes)
>> >> all:: compile_commands.json
>> >> compile_commands.json:
>> >> - @$(RM) $@
>> >> $(QUIET_GEN)sed -e '1s/^/[/' -e '$$s/,$$/]/' $(compdb_dir)/*.o.json > $@+
>> >> @if test -s $@+; then mv $@+ $@; else $(RM) $@+; fi
>> >> endif
>> >
>> > What about these?
>> >
>> > $(REMOTE_CURL_ALIASES):
>>
>> Uses a chain of ln/ln -s/cp, would need to add "-f" flags.
>
> Why? Isn't "x && a || b || c" the same as "a || b || c" if x is always true?
It does:
rm x &&
ln y x || ln -s y x || cp y x
If you run that you'll get a hardlink the first time around, but the
second time around you'll fall back to the "cp" if you remove the "rm".
>> > $(LIB_FILE):
>>
>> Can we rely on $(AR) happily clobbering things everywhere? Not knowing
>> is why I skipped it.
>
> We have c (create) in ARFLAGS, so presumably yes.
Will change.
>> > $(ETAGS_TARGET):
>> > tags:
>> > cscope:
>>
>> Addressed in the related:
>> https://lore.kernel.org/git/YNH+zsXDnRsT3uvZ@nand.local/T/#t
>
> I think ideally this patch should remove the $(RM) and the other patch
> should focus on the rest of the changes, but given the difficulty of
> landing chained patch series in git I understand the decision to clump
> them together.
>
> Cheers.
next prev parent reply other threads:[~2021-06-29 8:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:13 [PATCH] Makefile: add and use the ".DELETE_ON_ERROR" flag Ævar Arnfjörð Bjarmason
2021-06-22 15:27 ` Taylor Blau
2021-06-22 17:34 ` Ævar Arnfjörð Bjarmason
2021-06-22 19:17 ` Jeff King
2021-06-23 19:54 ` Ævar Arnfjörð Bjarmason
2021-06-23 22:21 ` Jeff King
2021-06-24 13:53 ` Ævar Arnfjörð Bjarmason
2021-06-24 14:49 ` Jeff King
2021-06-25 9:49 ` Ævar Arnfjörð Bjarmason
2021-06-29 2:26 ` Jeff King
2021-06-29 6:19 ` Junio C Hamano
2021-06-29 7:39 ` Ævar Arnfjörð Bjarmason
2021-06-29 21:38 ` Junio C Hamano
2021-06-30 2:23 ` Jeff King
2021-07-01 3:54 ` Felipe Contreras
2021-07-01 13:34 ` Ævar Arnfjörð Bjarmason
2021-07-03 0:41 ` Felipe Contreras
2021-07-03 12:31 ` Ævar Arnfjörð Bjarmason
2021-07-03 18:42 ` Felipe Contreras
2021-06-23 19:15 ` Felipe Contreras
2021-06-23 19:09 ` Felipe Contreras
2021-06-23 19:01 ` Felipe Contreras
2021-06-23 19:45 ` Ævar Arnfjörð Bjarmason
2021-06-23 20:32 ` Felipe Contreras
2021-06-29 7:29 ` Ævar Arnfjörð Bjarmason
2021-07-01 3:06 ` Felipe Contreras
2021-06-23 19:21 ` Felipe Contreras
2021-06-23 19:59 ` Ævar Arnfjörð Bjarmason
2021-06-23 20:52 ` Felipe Contreras
2021-06-29 8:17 ` Ævar Arnfjörð Bjarmason [this message]
2021-07-01 3:19 ` Felipe Contreras
2021-06-29 8:44 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-08-18 21:36 ` [PATCH] Makefile: remove archives before manipulating them with 'ar' SZEDER Gábor
2021-08-19 23:39 ` Junio C Hamano
2021-09-01 17:06 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735t1gk0d.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).