From: Felipe Contreras <felipe.contreras@gmail.com>
To: Gregory Anders <greg@gpanders.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v3] git-send-email: use ! to indicate relative path to command
Date: Tue, 11 May 2021 23:17:12 -0500 [thread overview]
Message-ID: <609b56c84a65_678ff208f1@natae.notmuch> (raw)
In-Reply-To: <YJs2RceLliGHI5TX@gpanders.com>
Gregory Anders wrote:
> On Tue, 11 May 2021 20:52 -0500, Felipe Contreras wrote:
> >> > I think simply sendemail.command is perfectly fine.
> >>
> >> Aren't there many other "commands" run by send-email, like --to-cmd and
> >> --cc-cmd? It probably should indicate somehow that it is the command for
> >> sending mail. I agree it does not have to say "SMTP". If it is meant to
> >> be compatible with sendmail, then maybe "sendemail.sendmailCommand" and
> >> "--sendmail-cmd" would work.
> >
> >Yes, although I find sendemail.sendmailCommand awfully redundant.
> >I would prefer sendemail.mainCommand, but to me sendemail.command
> >implies it's the main command as opposed to all ther other commands.
> >
> >Just like there's many presidents in USA (of companies, organizations,
> >and student unions), but when you say "the president of USA" it's
> >understood which president you are talking about.
>
> I agree with Jeff here. While I also find sendemail.sendmailCommand
> redundant, it makes more sense when used as a command line option:
>
> git send-email --sendmail-cmd <cmd>
>
> Conversely, `--command` is more ambiguous and less clear. Explicitly
> using `sendmailCommand` makes it clear that the user is specifying a
> command that is compatible with the `sendmail` program.
So would `git send-email --sendmail <cmd>`.
To make it clear, I think the options are:
1. `git send-email --sendmail <cmd>`: `sendemail.sendmail`
2. `git send-email --command <cmd>`: `sendemail.command`
I lean towards #2 since I think most people do a configuration and
forget about it it; they will rarely use the --command argument.
What I'm really against is:
sendemail.sendmail-command.sendmail = sendmail
Cheers.
--
Felipe Contreras
prev parent reply other threads:[~2021-05-12 4:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 19:15 [PATCH v3] git-send-email: use ! to indicate relative path to command Gregory Anders
2021-05-11 19:24 ` Jeff King
2021-05-11 20:40 ` [PATCH v4] " Gregory Anders
2021-05-11 21:39 ` Jeff King
2021-05-11 22:18 ` Gregory Anders
2021-05-11 23:09 ` Junio C Hamano
2021-05-11 23:49 ` [PATCH v5] " Gregory Anders
2021-05-12 0:00 ` brian m. carlson
2021-05-12 0:35 ` Jeff King
2021-05-12 0:45 ` Gregory Anders
2021-05-12 0:49 ` Jeff King
2021-05-12 3:29 ` Junio C Hamano
2021-05-12 0:51 ` brian m. carlson
2021-05-11 20:03 ` [PATCH v3] " Felipe Contreras
2021-05-11 20:42 ` Gregory Anders
2021-05-11 22:07 ` Felipe Contreras
2021-05-11 22:19 ` Gregory Anders
2021-05-12 0:47 ` Jeff King
2021-05-12 1:08 ` Felipe Contreras
2021-05-12 1:24 ` Jeff King
2021-05-12 1:52 ` Felipe Contreras
2021-05-12 1:58 ` Gregory Anders
2021-05-12 4:17 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609b56c84a65_678ff208f1@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=greg@gpanders.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).