From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>, Gregory Anders <greg@gpanders.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] git-send-email: use ! to indicate relative path to command
Date: Tue, 11 May 2021 20:08:50 -0500 [thread overview]
Message-ID: <609b2aa26aa5b_678ff20893@natae.notmuch> (raw)
In-Reply-To: <YJslulEQFvPkyo/R@coredump.intra.peff.net>
Jeff King wrote:
> On Tue, May 11, 2021 at 04:19:46PM -0600, Gregory Anders wrote:
> > Frankly I agree. Should I modify my patch to add this new option instead of
> > modifying the behavior of smtpServer? Obviously the smtpServer option would
> > need to preserve its current behavior for backward compatibility.
>
> Yeah, that was mentioned in the thread I linked earlier. I think it
> would be a fine solution, too. It would probably make sense for it to
> use the shell, as suggested elsewhere, and to call it "smtp-command" for
> consistency with other parts of Git (I'm thinking particularly of
> GIT_SSH versus GIT_SSH_COMMAND, where the latter was introduced to fix
> the defect that the former could not provide any arguments).
But it would be "smtpserver-command", and I don't think that the best
naming, because it doesn't necessarily have anything to do with SMTP, or
a server.
I think simply sendemail.command is perfectly fine.
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-12 1:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 19:15 [PATCH v3] git-send-email: use ! to indicate relative path to command Gregory Anders
2021-05-11 19:24 ` Jeff King
2021-05-11 20:40 ` [PATCH v4] " Gregory Anders
2021-05-11 21:39 ` Jeff King
2021-05-11 22:18 ` Gregory Anders
2021-05-11 23:09 ` Junio C Hamano
2021-05-11 23:49 ` [PATCH v5] " Gregory Anders
2021-05-12 0:00 ` brian m. carlson
2021-05-12 0:35 ` Jeff King
2021-05-12 0:45 ` Gregory Anders
2021-05-12 0:49 ` Jeff King
2021-05-12 3:29 ` Junio C Hamano
2021-05-12 0:51 ` brian m. carlson
2021-05-11 20:03 ` [PATCH v3] " Felipe Contreras
2021-05-11 20:42 ` Gregory Anders
2021-05-11 22:07 ` Felipe Contreras
2021-05-11 22:19 ` Gregory Anders
2021-05-12 0:47 ` Jeff King
2021-05-12 1:08 ` Felipe Contreras [this message]
2021-05-12 1:24 ` Jeff King
2021-05-12 1:52 ` Felipe Contreras
2021-05-12 1:58 ` Gregory Anders
2021-05-12 4:17 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609b2aa26aa5b_678ff20893@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=greg@gpanders.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).