From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Gregory Anders <greg@gpanders.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v5] git-send-email: use ! to indicate relative path to command
Date: Wed, 12 May 2021 00:00:51 +0000 [thread overview]
Message-ID: <YJsas0d4XPsYYpI7@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20210511234935.65147-1-greg@gpanders.com>
[-- Attachment #1: Type: text/plain, Size: 3159 bytes --]
On 2021-05-11 at 23:49:35, Gregory Anders wrote:
> The sendemail.smtpServer configuration option and the '--smtp-server'
> command line option can name a program to use by providing an absolute
> path to the program. However, an absolute path is not always portable
> and it is often preferable to simply specify a program name and have
> 'git-send-email' find that program on $PATH.
>
> For example, if a user wishes to use msmtp to send emails, they might
> be able to simply use
>
> [sendemail]
> smtpServer = !msmtp
>
> instead of using the full path. This is particularly useful when a
> common git config file is used across multiple systems where the
> absolute path to a given program may differ.
>
> To that end, this patch allows both the configuration and command line
> options to be prefixed with a '!' character to indicate that the
> specified command should be found on $PATH, as if the user had entered
> it directly on the command line.
I think the idea of providing a way to invoke a sendmail-compatible mail
server is a good idea.
> Signed-off-by: Gregory Anders <greg@gpanders.com>
> ---
> Diff from v4:
>
> * Update the test with suggestions from Jeff King (this should fix
> erroneous test failures caused by patch files being deleted by earlier
> tests)
> * Reword the commit message with feedback from Jeff King and Junio
> Hamano
>
> Documentation/git-send-email.txt | 13 +++++++------
> git-send-email.perl | 7 +++++--
> t/t9001-send-email.sh | 12 ++++++++++++
> 3 files changed, 24 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 93708aefea..418e66c703 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -212,12 +212,13 @@ a password is obtained using 'git-credential'.
> --smtp-server=<host>::
> If set, specifies the outgoing SMTP server to use (e.g.
> `smtp.example.com` or a raw IP address). Alternatively it can
> - specify a full pathname of a sendmail-like program instead;
> - the program must support the `-i` option. Default value can
> - be specified by the `sendemail.smtpServer` configuration
> - option; the built-in default is to search for `sendmail` in
> - `/usr/sbin`, `/usr/lib` and $PATH if such program is
> - available, falling back to `localhost` otherwise.
> + specify a sendmail-like program instead, either by a full
> + path-name or by prefixing the program name with `!`. The
> + program must support the `-i` option. Default value can be
> + specified by the `sendemail.smtpServer` configuration option;
> + the built-in default is to search for `sendmail` in `/usr/sbin`,
> + `/usr/lib` and $PATH if such program is available, falling back
> + to `localhost` otherwise.
Elsewhere we use the ! syntax we invoke the shell, and I would suggest
that we do the same here. That means we'll get PATH functionality by
default and we'll let people do a modicum of scripting if they like.
--
brian m. carlson (he/him or they/them)
Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2021-05-12 0:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 19:15 [PATCH v3] git-send-email: use ! to indicate relative path to command Gregory Anders
2021-05-11 19:24 ` Jeff King
2021-05-11 20:40 ` [PATCH v4] " Gregory Anders
2021-05-11 21:39 ` Jeff King
2021-05-11 22:18 ` Gregory Anders
2021-05-11 23:09 ` Junio C Hamano
2021-05-11 23:49 ` [PATCH v5] " Gregory Anders
2021-05-12 0:00 ` brian m. carlson [this message]
2021-05-12 0:35 ` Jeff King
2021-05-12 0:45 ` Gregory Anders
2021-05-12 0:49 ` Jeff King
2021-05-12 3:29 ` Junio C Hamano
2021-05-12 0:51 ` brian m. carlson
2021-05-11 20:03 ` [PATCH v3] " Felipe Contreras
2021-05-11 20:42 ` Gregory Anders
2021-05-11 22:07 ` Felipe Contreras
2021-05-11 22:19 ` Gregory Anders
2021-05-12 0:47 ` Jeff King
2021-05-12 1:08 ` Felipe Contreras
2021-05-12 1:24 ` Jeff King
2021-05-12 1:52 ` Felipe Contreras
2021-05-12 1:58 ` Gregory Anders
2021-05-12 4:17 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJsas0d4XPsYYpI7@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=greg@gpanders.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).