From: Brian Gernhardt <brian@gernhardtsoftware.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads
Date: Fri, 21 Jun 2013 14:15:39 -0400 [thread overview]
Message-ID: <603055CE-E8DE-4C53-9A7B-AE49CE515CCA@gernhardtsoftware.com> (raw)
In-Reply-To: <20130621181250.GA5290@sigill.intra.peff.net>
On Jun 21, 2013, at 2:12 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jun 21, 2013 at 02:08:49PM -0400, Brian Gernhardt wrote:
>
>> On Jun 21, 2013, at 2:03 PM, Jeff King <peff@peff.net> wrote:
>>
>>> IfVersion comes from mod_version. I assume that if it were not
>>> loaded, apache would complain about the directive entirely. But it's
>>> true that we don't load it until later. Maybe try moving the
>>> IfVersion/Lockfile stanza down below the mod_version LoadModule
>>> line?
>>
>> Apache is apparently overly accepting. Moving the IfVersion below all
>> the IfModules fixes it.
>
> Cool. I think the patch should look like the one below, then.
Basically identical to what I've done, you're just faster to the actual patch. :-D
+1
> Just to double-check that I have explained the issue correctly, can you
> share the output of "apache2 -l"? Mine has:
>
> $ apache2 -l
> Compiled in modules:
> core.c
> mod_log_config.c
> mod_logio.c
> mod_version.c
> prefork.c
> http_core.c
> mod_so.c
>
> which explains why it works here. I'm assuming you will not have
> mod_version.c compiled in.
Indeed I do not.
$ httpd -l
Compiled in modules:
core.c
prefork.c
http_core.c
mod_so.c
next prev parent reply other threads:[~2013-06-21 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 4:27 HTTP tests fail on OS X Brian Gernhardt
2013-06-21 4:30 ` Jeff King
2013-06-21 4:42 ` Jeff King
2013-06-21 4:45 ` Brian Gernhardt
2013-06-21 4:49 ` Jeff King
2013-06-21 17:03 ` Brian Gernhardt
2013-06-21 18:03 ` Jeff King
2013-06-21 18:08 ` Brian Gernhardt
2013-06-21 18:12 ` [PATCH] lib-httpd/apache.conf: check version only after mod_version loads Jeff King
2013-06-21 18:15 ` Brian Gernhardt [this message]
2013-06-21 18:18 ` Jeff King
2013-06-21 20:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603055CE-E8DE-4C53-9A7B-AE49CE515CCA@gernhardtsoftware.com \
--to=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).