From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Gernhardt Subject: Re: [PATCH] lib-httpd/apache.conf: check version only after mod_version loads Date: Fri, 21 Jun 2013 14:15:39 -0400 Message-ID: <603055CE-E8DE-4C53-9A7B-AE49CE515CCA@gernhardtsoftware.com> References: <20130621043052.GA5318@sigill.intra.peff.net> <20130621044236.GA5798@sigill.intra.peff.net> <26902D6D-D105-4943-BC67-461CEF82D888@gernhardtsoftware.com> <20130621044953.GA5962@sigill.intra.peff.net> <20130621180334.GA4499@sigill.intra.peff.net> <1B9251F9-C1AF-41F7-8BF8-D36DDB27EF09@gernhardtsoftware.com> <20130621181250.GA5290@sigill.intra.peff.net> Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Cc: Junio C Hamano , "git@vger.kernel.org List" To: Jeff King X-From: git-owner@vger.kernel.org Fri Jun 21 20:15:48 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uq5sC-00084z-6Q for gcvg-git-2@plane.gmane.org; Fri, 21 Jun 2013 20:15:48 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423558Ab3FUSPo (ORCPT ); Fri, 21 Jun 2013 14:15:44 -0400 Received: from vs072.rosehosting.com ([216.114.78.72]:58253 "EHLO silverinsanity.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423383Ab3FUSPo convert rfc822-to-8bit (ORCPT ); Fri, 21 Jun 2013 14:15:44 -0400 Received: by silverinsanity.com (Postfix, from userid 5001) id 2DA1627362F7; Fri, 21 Jun 2013 18:15:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on silverinsanity.com X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.5 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from [10.10.10.10] (cpe-142-105-190-134.rochester.res.rr.com [142.105.190.134]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by silverinsanity.com (Postfix) with ESMTPSA id 077E6273617E; Fri, 21 Jun 2013 18:15:39 +0000 (UTC) In-Reply-To: <20130621181250.GA5290@sigill.intra.peff.net> X-Mailer: Apple Mail (2.1508) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Jun 21, 2013, at 2:12 PM, Jeff King wrote: > On Fri, Jun 21, 2013 at 02:08:49PM -0400, Brian Gernhardt wrote: > >> On Jun 21, 2013, at 2:03 PM, Jeff King wrote: >> >>> IfVersion comes from mod_version. I assume that if it were not >>> loaded, apache would complain about the directive entirely. But it's >>> true that we don't load it until later. Maybe try moving the >>> IfVersion/Lockfile stanza down below the mod_version LoadModule >>> line? >> >> Apache is apparently overly accepting. Moving the IfVersion below all >> the IfModules fixes it. > > Cool. I think the patch should look like the one below, then. Basically identical to what I've done, you're just faster to the actual patch. :-D +1 > Just to double-check that I have explained the issue correctly, can you > share the output of "apache2 -l"? Mine has: > > $ apache2 -l > Compiled in modules: > core.c > mod_log_config.c > mod_logio.c > mod_version.c > prefork.c > http_core.c > mod_so.c > > which explains why it works here. I'm assuming you will not have > mod_version.c compiled in. Indeed I do not. $ httpd -l Compiled in modules: core.c prefork.c http_core.c mod_so.c