git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: "git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: HTTP tests fail on OS X
Date: Fri, 21 Jun 2013 00:30:52 -0400	[thread overview]
Message-ID: <20130621043052.GA5318@sigill.intra.peff.net> (raw)
In-Reply-To: <C44E969B-A5AE-44EF-BFCA-CAEF69516BEB@gernhardtsoftware.com>

On Fri, Jun 21, 2013 at 12:27:02AM -0400, Brian Gernhardt wrote:

> I've bisected it to this commit:
> 
> > commit 0442743810c6f6c14386a5a9d6bf8e4d69adbc51
> > Author: Jeff King <peff@peff.net>
> > Date:   Sun Jun 9 04:07:59 2013 -0400
> > 
> >     t/lib-httpd/apache.conf: do not use LockFile in apache >= 2.4
> 
> OS X 10.8.4, apache 2.2.22

Hrm. That's quite odd. The patch in its entirety looks like this:

diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
index 542241b..891edd7 100644
--- a/t/lib-httpd/apache.conf
+++ b/t/lib-httpd/apache.conf
@@ -1,5 +1,7 @@ LockFile accept.lock
 ServerName dummy
+<IfVersion < 2.4>
 LockFile accept.lock
+</IfVersion>
 PidFile httpd.pid
 DocumentRoot www

So it should not be having any effect at all on apache 2.2, unless it
somehow does not like the <IfVersion> tags.

Puzzled...

-Peff

  reply	other threads:[~2013-06-21  4:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-21  4:27 HTTP tests fail on OS X Brian Gernhardt
2013-06-21  4:30 ` Jeff King [this message]
2013-06-21  4:42   ` Jeff King
2013-06-21  4:45     ` Brian Gernhardt
2013-06-21  4:49       ` Jeff King
2013-06-21 17:03         ` Brian Gernhardt
2013-06-21 18:03           ` Jeff King
2013-06-21 18:08             ` Brian Gernhardt
2013-06-21 18:12               ` [PATCH] lib-httpd/apache.conf: check version only after mod_version loads Jeff King
2013-06-21 18:15                 ` Brian Gernhardt
2013-06-21 18:18                   ` Jeff King
2013-06-21 20:59                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130621043052.GA5318@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).