git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Dmitry Safonov" <0x7f454c46@gmail.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>,
	"Andrei Vagin" <avagin@openvz.org>
Subject: Re: [PATCHv3] send-email: Ask if a patch should be sent twice
Date: Wed, 31 Jul 2019 00:05:39 +0100	[thread overview]
Message-ID: <5775af07-f425-8192-3f2b-a45f21981407@arista.com> (raw)
In-Reply-To: <xmqq5znjrx0h.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On 7/30/19 11:13 PM, Junio C Hamano wrote:
> Dmitry Safonov <dima@arista.com> writes:
> 
>> I was almost certain that git won't let me send the same patch twice,
> 
> Why?  And more importantly, does it matter to readers of this
> message what you thought?

I see the point of putting description in impersonal, technical way.
Probably, was irritated after sending 50 patches instead of 37.
Also I've seen that in `git log | grep ' I '` over the project,
not that it justifies using it in the discussed patch.

> 
>> but today I've managed to double-send a directory by a mistake:
>> 	git send-email --to linux-kernel@vger.kernel.org /tmp/timens/
>> 	    --cc 'Dmitry Safonov <0x7f454c46@gmail.com>' /tmp/timens/`
>>
>> [I haven't noticed that I put the directory twice ^^]
>>
>> Prevent this shipwreck from happening again by asking if a patch
>> is sent multiple times on purpose.
>>
>> link: https://lkml.kernel.org/r/4d53ebc7-d5b2-346e-c383-606401d19d3a@gmail.com
> 
> What does "link:" mean?

It's a tag, usually used to point URL for more information.
Maybe not that common in git-ml, but often it shows an example of what
can go wrong without a patch.

> 
>> Cc: Andrei Vagin <avagin@openvz.org>
> 
> What's the significance for this project to record that this patch
> was CCed to Andrei?

I've felt like I need to give credit to my friend with whom I was
working on the patches set; which I've failed to send properly.
Maybe it's a thing of more opensource-friendly communities like lkml.

> 
>> Suggested-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> 
> I think "Helped-by:" is a lot more appropriate, viewing the exchange
> on v2 from the sideline.
> 
>> Signed-off-by: Dmitry Safonov <dima@arista.com>

To be honest, I don't feel like going on with v5.
I've underestimate how welcoming some communities are to foreign patches.

If you feel like it's still worth to have the feature, please carry-on
with the tag
Abandoned-by: Dmitry Safonov <dima@arista.com>
and don't drop Cc tag.

[..]
Thanks and sorry for waisted time,
          Dmitry

      parent reply	other threads:[~2019-07-30 23:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 20:33 Dmitry Safonov
2019-07-30 21:10 ` SZEDER Gábor
2019-07-30 21:19   ` Dmitry Safonov
2019-07-30 22:13 ` Junio C Hamano
2019-07-30 22:56   ` Andrey Vagin
2019-07-31  1:06     ` Jeff King
2019-07-30 23:05   ` Dmitry Safonov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5775af07-f425-8192-3f2b-a45f21981407@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=avagin@openvz.org \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=szeder.dev@gmail.com \
    --subject='Re: [PATCHv3] send-email: Ask if a patch should be sent twice' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).