From: Dmitry Safonov <dima@arista.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Dmitry Safonov" <0x7f454c46@gmail.com>,
"Andrei Vagin" <avagin@openvz.org>
Subject: Re: [PATCHv3] send-email: Ask if a patch should be sent twice
Date: Tue, 30 Jul 2019 22:19:08 +0100 [thread overview]
Message-ID: <e12b1d56-717e-2b1e-8475-9353a855e343@arista.com> (raw)
In-Reply-To: <20190730211012.GS20404@szeder.dev>
On 7/30/19 10:10 PM, SZEDER Gábor wrote:
> On Tue, Jul 30, 2019 at 09:33:27PM +0100, Dmitry Safonov wrote:
>> @@ -589,6 +591,19 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' '
>> test_cmp expect actual
>> '
>>
>> +test_expect_success $PREREQ 'ask confirmation for double-send' '
>> + clean_fake_sendmail &&
>> + echo y | \
>> + GIT_SEND_EMAIL_NOTTY=1 \
>> + git send-email --from=author@example.com \
>> + --to=nobody@example.com \
>> + --smtp-server="$(pwd)/fake.sendmail" \
>> + --validate \
>> + $patches $patches $patches \
>> + >stdout &&
>> + ! test_i18ngrep "Patches specified several times: " stdout
>
> You should write this as 'test_i18ngrep ! <...>'. When running the
> test with GIT_TEST_GETTEXT_POISON=true, then 'test_i18ngrep' is
> basically a noop and always returns with success, the leading ! would
> turn that into a failure, which then would fail the test.
>
> Sorry for not being specific enough.
No worries, thanks for the review anyway, quite educative - I haven't
worked much on i18-related things in other projects, so sorry for not
getting it straight away.
Will resend shortly..
Thanks,
Dmtiry
next prev parent reply other threads:[~2019-07-30 21:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 20:33 [PATCHv3] send-email: Ask if a patch should be sent twice Dmitry Safonov
2019-07-30 21:10 ` SZEDER Gábor
2019-07-30 21:19 ` Dmitry Safonov [this message]
2019-07-30 22:13 ` Junio C Hamano
2019-07-30 22:56 ` Andrey Vagin
2019-07-31 1:06 ` Jeff King
2019-07-30 23:05 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e12b1d56-717e-2b1e-8475-9353a855e343@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@openvz.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).