git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Andrey Vagin <avagin@openvz.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Dmitry Safonov" <dima@arista.com>,
	git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Dmitry Safonov" <0x7f454c46@gmail.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCHv3] send-email: Ask if a patch should be sent twice
Date: Tue, 30 Jul 2019 21:06:25 -0400	[thread overview]
Message-ID: <20190731010625.GB9610@sigill.intra.peff.net> (raw)
In-Reply-To: <CANaxB-yygbxt=-sP+cyhR9WhcyEck+Wy=453huwfVNC9+So0BA@mail.gmail.com>

On Tue, Jul 30, 2019 at 03:56:43PM -0700, Andrey Vagin wrote:

> On Tue, Jul 30, 2019 at 3:13 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Dmitry Safonov <dima@arista.com> writes:
> >
> > > I was almost certain that git won't let me send the same patch twice,
> >
> > Why?  And more importantly, does it matter to readers of this
> > message what you thought?
> 
> Sounds rude. What matter to readers except author's thoughts? I guess you want
> to say that the comment should be in more neutral technical form without
> personal pronouns.

IMHO it's OK to use personal pronouns, but it's good to stick to the
facts. It's easy to go off on a tangent about what led you to the patch
that ends up making it harder for somebody reading the patch later to
get to the point.

In this case, you did the leg-work to advance the story from "I'm
confused about it should do..." to "it definitely does X now, and it
would be better if it did Y". That's probably the best place for a later
reader of the commit message to pick it up.

-Peff

PS I agree that what Junio wrote does sound a bit rude, but I don't
   think that was his intent. It's easy to accidentally be a little too
   curt during reviews (and I'm sure I've done it myself many times).
   Hopefully we can all take this as a reminder to be careful. :)

  reply	other threads:[~2019-07-31  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 20:33 Dmitry Safonov
2019-07-30 21:10 ` SZEDER Gábor
2019-07-30 21:19   ` Dmitry Safonov
2019-07-30 22:13 ` Junio C Hamano
2019-07-30 22:56   ` Andrey Vagin
2019-07-31  1:06     ` Jeff King [this message]
2019-07-30 23:05   ` Dmitry Safonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731010625.GB9610@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=0x7f454c46@gmail.com \
    --cc=avagin@openvz.org \
    --cc=avarab@gmail.com \
    --cc=dima@arista.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=szeder.dev@gmail.com \
    --subject='Re: [PATCHv3] send-email: Ask if a patch should be sent twice' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).