From: Michael Haggerty <mhagger@alum.mit.edu>
To: William Duclot <william.duclot@ensimag.grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, antoine.queru@ensimag.grenoble-inp.fr,
francois.beutin@ensimag.grenoble-inp.fr,
Johannes.Schindelin@gmx.de, mh@glandium.org
Subject: Re: [PATCH V2 3/3] strbuf: allow to use preallocated memory
Date: Wed, 8 Jun 2016 18:20:41 +0200 [thread overview]
Message-ID: <575845D9.2010604@alum.mit.edu> (raw)
In-Reply-To: <20160607090653.GA4665@Messiaen>
On 06/07/2016 11:06 AM, William Duclot wrote:
> [...]
> The "fixed" feature was aimed to allow the users to use strbuf with
> strings that they doesn't own themselves (a function parameter for
> example). From Michael example in the original mail:
>
> void f(char *path_buf, size_t path_buf_len)
> {
> struct strbuf path;
> strbuf_wrap_fixed(&path, path_buf,
> strlen(path_buf),
> path_buf_len);
> ...
I also thought that "fixed" strbufs would be useful in cases where you
*know* what size string you need and only want a strbuf wrapper because
it offers a lot of convenience functions. Nowadays we would do that
using something like
> static int feed_object(const unsigned char *sha1, int fd, int negative)
> {
> char buf[42];
>
> if (negative && !has_sha1_file(sha1))
> return 1;
>
> memcpy(buf + negative, sha1_to_hex(sha1), 40);
> if (negative)
> buf[0] = '^';
> buf[40 + negative] = '\n';
> return write_or_whine(fd, buf, 41 + negative, "send-pack: send refs");
> }
Instead, one could write
> static int feed_object(const unsigned char *sha1, int fd, int negative)
> {
> char buf[GIT_SHA1_HEXSZ + 2];
> struct strbuf line = WRAPPED_FIXED_STRBUF(buf);
>
> if (negative && !has_sha1_file(sha1))
> return 1;
>
> if (negative)
> strbuf_addch(&line, '^');
> strbuf_add(&line, sha1_to_hex(sha1), GIT_SHA1_HEXSZ);
> strbuf_addch(&line, '\n');
> return write_or_whine(fd, line.buf, line.len, "send-pack: send refs");
> }
* It's a little less manual bookkeeping, and thus less error-prone,
than the current code.
* If somebody decides to add another character to the line but
forgets to increase the allocation size, the code dies in testing
rather than (a) overflowing the buffer, like the current
code, or (b) silently becoming less performant, as if it used a
preallocated but non-fixed strbuf.
* There's no need to strbuf_release() (which can be convenient in
a function with multiple exit paths).
I don't know whether this particular function should be rewritten; I'm
just giving an example of the type of scenario where I think it could be
useful.
In a world without fixed strbufs, what would one use in this situation?
Michael
next prev parent reply other threads:[~2016-06-08 16:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 15:13 [PATCH V2 0/3] strbuf: improve API William Duclot
2016-06-06 15:13 ` [PATCH V2 1/3] strbuf: add tests William Duclot
2016-06-06 16:11 ` Matthieu Moy
2016-06-07 8:44 ` Johannes Schindelin
2016-06-06 15:13 ` [PATCH V2 2/3] pretty.c: rename strbuf_wrap() function William Duclot
2016-06-06 16:12 ` Matthieu Moy
2016-06-07 9:04 ` Johannes Schindelin
2016-06-06 15:13 ` [PATCH V2 3/3] strbuf: allow to use preallocated memory William Duclot
2016-06-06 16:17 ` Matthieu Moy
2016-06-06 17:19 ` Junio C Hamano
2016-06-06 20:39 ` William Duclot
2016-06-06 22:44 ` Junio C Hamano
2016-06-06 22:58 ` Jeff King
2016-06-06 23:24 ` Junio C Hamano
2016-06-06 23:25 ` Junio C Hamano
2016-06-06 23:30 ` Jeff King
2016-06-07 9:06 ` William Duclot
2016-06-07 18:10 ` Junio C Hamano
2016-06-08 16:20 ` Michael Haggerty [this message]
2016-06-08 18:07 ` Junio C Hamano
2016-06-08 19:19 ` Jeff King
2016-06-08 19:42 ` [PATCH] send-pack: use buffered I/O to talk to pack-objects Jeff King
2016-06-09 12:10 ` Matthieu Moy
2016-06-09 14:34 ` Ramsay Jones
2016-06-09 17:12 ` Jeff King
2016-06-09 22:40 ` Ramsay Jones
2016-06-09 16:40 ` Junio C Hamano
2016-06-09 17:14 ` Jeff King
2016-06-09 17:22 ` Matthieu Moy
2016-06-08 19:48 ` [PATCH V2 3/3] strbuf: allow to use preallocated memory Junio C Hamano
2016-06-08 19:52 ` Jeff King
2016-06-08 23:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575845D9.2010604@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=Johannes.Schindelin@gmx.de \
--cc=antoine.queru@ensimag.grenoble-inp.fr \
--cc=francois.beutin@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=peff@peff.net \
--cc=william.duclot@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).