From: Martin Fick <mfick@codeaurora.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
"Lars Schneider" <larsxschneider@gmail.com>,
git <git@vger.kernel.org>, "Jeff King" <peff@peff.net>,
"Duy Nguyen" <pclouds@gmail.com>
Subject: Re: worktrees vs. alternates
Date: Wed, 16 May 2018 13:18:20 -0600 [thread overview]
Message-ID: <5484271.13heo1O2yY@mfick-lnx> (raw)
In-Reply-To: <4a18e167-8cec-0141-fe2c-4e0a35f16daf@linuxfoundation.org>
On Wednesday, May 16, 2018 03:11:47 PM Konstantin Ryabitsev
wrote:
> On 05/16/18 15:03, Martin Fick wrote:
> >> I'm undecided about that. On the one hand this does
> >> create lots of small files and inevitably causes
> >> (some) performance degradation. On the other hand, I
> >> don't want to keep useless objects in the pack,
> >> because that would also cause performance degradation
> >> for people cloning the "mother repo." If my
> >> assumptions on any of that are incorrect, I'm happy to
> >> learn more.
> >
> > My suggestion is to use science, not logic or hearsay.
> > :)
> > i.e. test it!
>
> I think the answer will be "it depends." In many of our
> cases the repos that need those loose objects are rarely
> accessed -- usually because they are forks with older
> data (hence why they need objects that are no longer used
> by the mother repo). Therefore, performance impacts of
> occasionally touching a handful of loose objects will be
> fairly negligible. This is especially true on
> non-spinning media where seek times are low anyway.
> Having slimmer packs for the mother repo would be more
> beneficial in this case.
>
> On the other hand, if the "child repo" is frequently used,
> then the impact of needing a bunch of loose objects would
> be greater. For the sake of simplicity, I think I'll
> leave things as they are -- it's cheaper to fix this via
> reducing seek times than by applying complicated logic
> trying to optimize on a per-repo basis.
I think a major performance issue with loose objects is not
just the seek time, but also the fact that they are not
delta compressed. This means that sending them over the
wire will likely have a significant cost before sending it.
Unlike the seek time, this cost is not mitigated across
concurrent fetches by the FS (or jgit if you were to use it)
caching,
-Martin
--
The Qualcomm Innovation Center, Inc. is a member of Code
Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-05-16 19:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 8:13 worktrees vs. alternates Lars Schneider
2018-05-16 9:29 ` Ævar Arnfjörð Bjarmason
2018-05-16 9:42 ` Robert P. J. Day
2018-05-16 11:07 ` Ævar Arnfjörð Bjarmason
2018-05-16 9:51 ` Lars Schneider
2018-05-16 10:33 ` Ævar Arnfjörð Bjarmason
2018-05-16 13:02 ` Derrick Stolee
2018-05-16 14:58 ` Konstantin Ryabitsev
2018-05-16 15:34 ` Ævar Arnfjörð Bjarmason
2018-05-16 15:49 ` Konstantin Ryabitsev
2018-05-16 17:54 ` Ævar Arnfjörð Bjarmason
2018-05-16 17:14 ` Martin Fick
2018-05-16 17:41 ` Konstantin Ryabitsev
2018-05-16 18:02 ` Ævar Arnfjörð Bjarmason
2018-05-16 18:12 ` Konstantin Ryabitsev
2018-05-16 18:26 ` Martin Fick
2018-05-16 19:01 ` Konstantin Ryabitsev
2018-05-16 19:03 ` Martin Fick
2018-05-16 19:11 ` Konstantin Ryabitsev
2018-05-16 19:18 ` Martin Fick [this message]
2018-05-16 19:23 ` Jeff King
2018-05-16 19:29 ` Konstantin Ryabitsev
2018-05-16 19:37 ` Jeff King
2018-05-16 19:40 ` Martin Fick
2018-05-16 20:06 ` Jeff King
2018-05-16 20:43 ` Martin Fick
2018-05-16 20:02 ` Konstantin Ryabitsev
2018-05-16 20:17 ` Jeff King
2018-05-17 0:43 ` Sitaram Chamarty
2018-05-17 3:31 ` Jeff King
2018-05-19 5:45 ` Duy Nguyen
2018-05-16 19:14 ` Jeff King
2018-05-16 21:18 ` Stefan Beller
2018-05-16 23:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5484271.13heo1O2yY@mfick-lnx \
--to=mfick@codeaurora.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=larsxschneider@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).