From: Steven Grimm <koreth@midwinter.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"Michael S. Tsirkin" <mst@dev.mellanox.co.il>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] diff: resurrect the traditional empty "diff --git" behaviour
Date: Fri, 31 Aug 2007 15:37:56 -0700 [thread overview]
Message-ID: <46D89844.8050605@midwinter.com> (raw)
In-Reply-To: <7vtzqfzcll.fsf_-_@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> This commit reinstates the traditional behaviour as the default,
> but with a twist.
>
> If you set diff.autorefreshindex configuration variable, it
> squelches the empty "diff --git" output, and at the end of the
> command, it automatically runs "update-index --refresh" without
> even bothering the user. In other words, with the configuration
> variable set, people who do not care about the cache-dirtyness
> do not even have to see the warning.
>
As the person who submitted the patch you're reversing with this, I
agree 100% this is the better approach. Having the system self-heal is
far preferable to requiring user action.
I would vote for reversing the sense of that config variable, actually:
my guess is that most users, especially new ones who won't necessarily
know about the config variable, would rather have git just keep itself
healthy without user intervention. Having to manually update the index
is (by virtue of requiring you to run a command that you wouldn't
otherwise need to run) a mode more suited to advanced / experienced
users, who are more likely to already be comfortable with the idea of
flipping config switches. Making the more novice-friendly mode require
that you know how to set a particular configuration variable doesn't
seem right to me.
-Steve
next prev parent reply other threads:[~2007-08-31 22:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 6:38 parallel make problem with git Michael S. Tsirkin
2007-08-30 6:46 ` Junio C Hamano
2007-08-30 6:50 ` Michael S. Tsirkin
2007-08-30 7:27 ` [PATCH] fix parallel make problem Michael S. Tsirkin
2007-08-31 2:02 ` Junio C Hamano
2007-08-31 8:06 ` Michael S. Tsirkin
2007-08-31 8:12 ` Junio C Hamano
2007-08-31 8:15 ` Michael S. Tsirkin
2007-08-31 8:36 ` Junio C Hamano
2007-08-31 15:21 ` Michael S. Tsirkin
2007-08-31 15:44 ` Junio C Hamano
2007-08-31 16:00 ` Michael S. Tsirkin
2007-08-31 16:11 ` Johannes Schindelin
2007-08-31 16:01 ` Junio C Hamano
2007-08-31 16:03 ` Jeff King
2007-08-31 20:13 ` [PATCH] diff: resurrect the traditional empty "diff --git" behaviour Junio C Hamano
2007-08-31 20:32 ` Jeff King
2007-08-31 20:57 ` Johannes Schindelin
2007-08-31 21:16 ` Junio C Hamano
2007-08-31 21:30 ` Johannes Schindelin
2007-08-31 21:20 ` David Kastrup
2007-08-31 21:32 ` Alex Riesen
2007-08-31 22:37 ` Steven Grimm [this message]
2007-09-01 1:27 ` Junio C Hamano
2007-09-03 8:09 ` Matthieu Moy
2007-09-03 8:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D89844.8050605@midwinter.com \
--to=koreth@midwinter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mst@dev.mellanox.co.il \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).