git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Michael S. Tsirkin" <mst@dev.mellanox.co.il>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Michael S. Tsirkin" <mst@dev.mellanox.co.il>, git@vger.kernel.org
Subject: Re: [PATCH] fix parallel make problem
Date: Fri, 31 Aug 2007 11:06:51 +0300	[thread overview]
Message-ID: <20070831080651.GA17637@mellanox.co.il> (raw)
In-Reply-To: <7vmyw85uml.fsf@gitster.siamese.dyndns.org>

> Quoting Junio C Hamano <gitster@pobox.com>:
> Subject: Re: [PATCH] fix parallel make problem
> 
> How about this as a replacement?  I notice that after a
> successful build all the test-*.o files are removed by make, and
> somehow make seems to believe it is Ok not to recreate them.

Yea. this works for me.

> ---
>  Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 4eb4637..51af531 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -969,6 +969,8 @@ test-date$X: date.o ctype.o
>  
>  test-delta$X: diff-delta.o patch-delta.o
>  
> +.PRECIOUS: $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))
> +
>  test-%$X: test-%.o $(GITLIBS)
>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS)

Add a comment here?
	
> Warning: 1 path touched but unmodified. Consider running git-status.

BTW, shouldn't the warning go to standard error?

-- 
MST

  reply	other threads:[~2007-08-31  8:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30  6:38 parallel make problem with git Michael S. Tsirkin
2007-08-30  6:46 ` Junio C Hamano
2007-08-30  6:50   ` Michael S. Tsirkin
2007-08-30  7:27   ` [PATCH] fix parallel make problem Michael S. Tsirkin
2007-08-31  2:02     ` Junio C Hamano
2007-08-31  8:06       ` Michael S. Tsirkin [this message]
2007-08-31  8:12         ` Junio C Hamano
2007-08-31  8:15           ` Michael S. Tsirkin
2007-08-31  8:36             ` Junio C Hamano
2007-08-31 15:21               ` Michael S. Tsirkin
2007-08-31 15:44                 ` Junio C Hamano
2007-08-31 16:00                   ` Michael S. Tsirkin
2007-08-31 16:11                     ` Johannes Schindelin
2007-08-31 16:01                   ` Junio C Hamano
2007-08-31 16:03                   ` Jeff King
2007-08-31 20:13                     ` [PATCH] diff: resurrect the traditional empty "diff --git" behaviour Junio C Hamano
2007-08-31 20:32                       ` Jeff King
2007-08-31 20:57                         ` Johannes Schindelin
2007-08-31 21:16                           ` Junio C Hamano
2007-08-31 21:30                             ` Johannes Schindelin
2007-08-31 21:20                           ` David Kastrup
2007-08-31 21:32                       ` Alex Riesen
2007-08-31 22:37                       ` Steven Grimm
2007-09-01  1:27                         ` Junio C Hamano
2007-09-03  8:09                           ` Matthieu Moy
2007-09-03  8:36                             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070831080651.GA17637@mellanox.co.il \
    --to=mst@dev.mellanox.co.il \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).