From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Subject: Re: [PATCH] diff: resurrect the traditional empty "diff --git" behaviour
Date: Fri, 31 Aug 2007 16:32:50 -0400 [thread overview]
Message-ID: <20070831203250.GA19340@coredump.intra.peff.net> (raw)
In-Reply-To: <7vtzqfzcll.fsf_-_@gitster.siamese.dyndns.org>
On Fri, Aug 31, 2007 at 01:13:42PM -0700, Junio C Hamano wrote:
> If you set diff.autorefreshindex configuration variable, it
> squelches the empty "diff --git" output, and at the end of the
> command, it automatically runs "update-index --refresh" without
> even bothering the user. In other words, with the configuration
> variable set, people who do not care about the cache-dirtyness
> do not even have to see the warning.
Nice. This is much more sane behavior, IMHO, and I think it should make
everyone happy.
> Same here. This patch saw only very light testing, but I
> personally think is a sane thing to do before 1.5.3 final.
Passes my light testing as well, but I have a feeling we just tested the
same things...;)
One question on the implementation (and remember that I am somewhat
ignorant of the structure of this part of the code, so the answer may be
"it's too ugly"): is there a good reason to refresh _after_ the diff? It
seems like when we are looking through the working tree and index the
first time, we notice that the stat information doesn't match; why can't
we update it then? That would save an extra working tree traversal.
-Peff
next prev parent reply other threads:[~2007-08-31 20:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 6:38 parallel make problem with git Michael S. Tsirkin
2007-08-30 6:46 ` Junio C Hamano
2007-08-30 6:50 ` Michael S. Tsirkin
2007-08-30 7:27 ` [PATCH] fix parallel make problem Michael S. Tsirkin
2007-08-31 2:02 ` Junio C Hamano
2007-08-31 8:06 ` Michael S. Tsirkin
2007-08-31 8:12 ` Junio C Hamano
2007-08-31 8:15 ` Michael S. Tsirkin
2007-08-31 8:36 ` Junio C Hamano
2007-08-31 15:21 ` Michael S. Tsirkin
2007-08-31 15:44 ` Junio C Hamano
2007-08-31 16:00 ` Michael S. Tsirkin
2007-08-31 16:11 ` Johannes Schindelin
2007-08-31 16:01 ` Junio C Hamano
2007-08-31 16:03 ` Jeff King
2007-08-31 20:13 ` [PATCH] diff: resurrect the traditional empty "diff --git" behaviour Junio C Hamano
2007-08-31 20:32 ` Jeff King [this message]
2007-08-31 20:57 ` Johannes Schindelin
2007-08-31 21:16 ` Junio C Hamano
2007-08-31 21:30 ` Johannes Schindelin
2007-08-31 21:20 ` David Kastrup
2007-08-31 21:32 ` Alex Riesen
2007-08-31 22:37 ` Steven Grimm
2007-09-01 1:27 ` Junio C Hamano
2007-09-03 8:09 ` Matthieu Moy
2007-09-03 8:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831203250.GA19340@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mst@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).