From: Luke Lu <git@vicaya.com>
To: git@vger.kernel.org
Subject: [PATCH] gitweb: Speed up get_projects_list for large source trees
Date: Tue, 16 Oct 2007 02:04:14 -0700 [thread overview]
Message-ID: <3A2DCEC6-953A-41B0-AB9E-7374EEB625E8@vicaya.com> (raw)
In-Reply-To: <vpqlka3sdka.fsf@bauges.imag.fr>
Hi, I've been using git for a month now and loving it. This is my
first ever patch for git using git. I spent sometime to find out why
the project listing is taking 200s, everytime! I guess that gitweb is
mostly used to serve bare repositories, which would never encounter
such problems. It takes .2s, after the patch on my laptop. That's
1000x improvement for me (on Mac OS X 1.4.10.)
__Luke
Signed-off-by: Luke Lu <git@vicaya.com>
---
gitweb/gitweb.perl | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 3064298..a30eef9 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1509,16 +1509,20 @@ sub git_get_projects_list {
# remove the trailing "/"
$dir =~ s!/+$!!;
my $pfxlen = length("$dir");
+ my $pfxdepth = ($dir =~ tr!/!!);
File::Find::find({
follow_fast => 1, # follow symbolic links
follow_skip => 2, # ignore duplicates
+ no_chdir => 1, # don't chdir into every directory
dangling_symlinks => 0, # ignore dangling symlinks, silently
wanted => sub {
# skip project-list toplevel, if we get it.
return if (m!^[/.]$!);
# only directories can be git repositories
return unless (-d $_);
+ # don't traverse too deep (Find is super slow on os x)
+ return if tr!/!! - $pfxdepth > 2 && ($File::Find::prune = 1);
my $subdir = substr($File::Find::name, $pfxlen + 1);
# we check related file in $projectroot
--
1.5.3.4
next prev parent reply other threads:[~2007-10-16 9:05 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 21:38 [PATCH] Git homepage: remove all the references to Cogito Paolo Ciarrocchi
2007-10-16 2:19 ` Petr Baudis
2007-10-16 7:50 ` Matthieu Moy
2007-10-16 8:01 ` Paolo Ciarrocchi
2007-10-16 9:04 ` Luke Lu [this message]
2007-10-16 16:55 ` [PATCH] gitweb: Speed up get_projects_list for large source trees Andreas Ericsson
2007-10-16 23:20 ` Petr Baudis
2007-10-16 10:49 ` cogito and remote#branch, was Re: [PATCH] Git homepage: remove all the references to Cogito Johannes Schindelin
2007-10-16 21:09 ` remote#branch Jan Hudec
2007-10-16 21:35 ` remote#branch Johannes Schindelin
2007-10-27 20:47 ` remote#branch Jan Hudec
2007-10-27 23:01 ` remote#branch Johannes Schindelin
2007-10-29 17:40 ` remote#branch Jan Hudec
2007-10-29 18:17 ` remote#branch Linus Torvalds
2007-10-29 21:49 ` remote#branch Theodore Tso
2007-10-29 22:57 ` remote#branch Linus Torvalds
2007-10-29 23:49 ` remote#branch Johannes Schindelin
2007-10-30 3:01 ` remote#branch Theodore Tso
2007-10-30 3:40 ` remote#branch Junio C Hamano
2007-10-30 4:40 ` remote#branch Theodore Tso
2007-10-30 4:51 ` remote#branch Linus Torvalds
2007-10-30 5:37 ` remote#branch Tom Prince
2007-10-30 14:59 ` remote#branch Linus Torvalds
2007-10-30 16:02 ` remote#branch Tom Prince
2007-10-30 17:39 ` remote#branch Linus Torvalds
2007-10-30 17:49 ` remote#branch Matthieu Moy
2007-10-30 17:58 ` remote#branch Linus Torvalds
2007-10-30 18:19 ` remote#branch Linus Torvalds
2007-10-30 19:18 ` remote#branch Pascal Obry
2007-10-30 19:38 ` remote#branch Linus Torvalds
2007-10-30 20:15 ` remote#branch Randal L. Schwartz
2007-10-30 20:30 ` remote#branch Linus Torvalds
2007-10-30 20:36 ` remote#branch Nicolas Pitre
2007-10-30 23:58 ` remote#branch Jeff King
2007-10-31 0:12 ` remote#branch Jakub Narebski
2007-10-31 1:38 ` remote#branch Jeff King
2007-10-31 1:49 ` remote#branch Jakub Narebski
2007-10-31 1:57 ` remote#branch Jeff King
2007-10-31 7:09 ` remote#branch Andreas Ericsson
2007-10-31 8:35 ` remote#branch Mike Hommey
2007-10-31 9:03 ` remote#branch Andreas Ericsson
2007-10-31 9:15 ` remote#branch Mike Hommey
2007-11-01 0:22 ` remote#branch Jakub Narebski
2007-11-01 5:11 ` remote#branch Theodore Tso
2007-11-01 7:29 ` remote#branch Andreas Ericsson
2007-10-31 9:33 ` remote#branch Pascal Obry
2007-10-31 6:42 ` remote#branch David Kastrup
2007-10-31 15:28 ` remote#branch Linus Torvalds
2007-10-31 20:47 ` remote#branch Jeff King
2007-10-31 21:01 ` remote#branch Linus Torvalds
2007-10-31 21:26 ` remote#branch Jeff King
2007-10-31 21:28 ` remote#branch Linus Torvalds
2007-10-31 21:07 ` remote#branch Andreas Ericsson
2007-10-31 21:31 ` remote#branch Jeff King
2007-10-31 6:39 ` remote#branch David Kastrup
2007-10-31 8:16 ` remote#branch Wincent Colaiuta
2007-10-31 8:25 ` remote#branch Robin Rosenberg
2007-10-31 9:34 ` remote#branch Pascal Obry
2007-10-31 17:13 ` remote#branch Petr Baudis
2007-10-30 19:15 ` remote#branch Pascal Obry
2007-10-30 19:36 ` remote#branch Jan Hudec
2007-10-30 19:53 ` remote#branch Linus Torvalds
2007-10-31 19:29 ` remote#branch Erik Warendorph
2007-10-30 10:02 ` remote#branch Johannes Schindelin
2007-10-31 0:41 ` remote#branch Martin Langhoff
2007-10-31 0:59 ` remote#branch Linus Torvalds
2007-10-31 1:43 ` remote#branch Jeff King
2007-10-31 1:49 ` remote#branch Martin Langhoff
2007-10-31 1:59 ` remote#branch Jeff King
2007-10-31 3:08 ` remote#branch Johannes Schindelin
2007-10-30 4:50 ` remote#branch Linus Torvalds
2007-10-29 18:32 ` remote#branch Johannes Schindelin
2007-10-16 22:16 ` cogito and remote#branch, was Re: [PATCH] Git homepage: remove all the references to Cogito Jonas Fonseca
2007-10-31 17:09 ` Petr Baudis
2007-10-31 21:17 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A2DCEC6-953A-41B0-AB9E-7374EEB625E8@vicaya.com \
--to=git@vicaya.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).