From: Jeff King <peff@peff.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Kastrup <dak@gnu.org>, Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org
Subject: Re: remote#branch
Date: Wed, 31 Oct 2007 17:26:55 -0400 [thread overview]
Message-ID: <20071031212655.GB13823@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LFD.0.999.0710311350100.3342@woody.linux-foundation.org>
On Wed, Oct 31, 2007 at 02:01:54PM -0700, Linus Torvalds wrote:
> > Yes, this means that if you have a bizarre repo name, you can't
> > necessarily switch between host:file syntax and git:// syntax by simple
> > cut and paste. But you really can't _anyway_, since there is no
> > guarantee that they are rooted at the same location, or have the same
> > view of the filesystem.
>
> .. but in practice it works fine, especially for something like kernel.org
> where it really *is* the same filesystem, just mirrored out.
Yes, and in practice, it works with or without URL encoding, since
people aren't using names that need encoded.
> Also, more importantly, I think the quoting is *stupid*. It adds pointless
> code for absolutely zero gain. Are you going to unquote '/'? Or how about
> '~'?
I don't think it's zero gain; I think it's exactly what users who use
repos with characters that need quoting will expect to happen. That
being said, _I_ don't personally care that much since I think spaces in
filenames are the work of the devil, and I will never use them. And as a
result, I'm not going to implement the code to do it.
But I do think your argument that there is no value in the URL syntax is
just wrong.
I don't understand your mention of '~' and '/'; they don't need quoted
in URLs, and generally are not (though of course they can be).
> .. because it's a simple format, and it *works*. The same way INI config
> files are simple and *work*.
But if you wrote a bunch of documentation referring to the git config
file as an INI file, would you expect people to complain when it
_didn't_ follow the usual expectation for INI files?
OK, this discussion is just getting nowhere, and there is useful git
work I could be doing, so let me sum up my position:
- We should either resolve that some repo specifiers are URLs, or we
should resolve that they are not. I think they are.
- If they are URLs, then we should treat them like URLs, and not
handling quoting is probably a bug. I refuse to accept that it is an
_important_ bug until somebody actually has a repo that needs
quoting, finds that git is substandard, and provides a patch.
- If they are not URLs, then we should probably stop calling them that
in the documentation.
And with that, I shall say no more on the subject. In the spirit of not
saying "oh, I don't want to talk about it anymore, you don't get to say
anything else," I invite you to respond to any of my comments above.
-Peff
next prev parent reply other threads:[~2007-10-31 21:27 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 21:38 [PATCH] Git homepage: remove all the references to Cogito Paolo Ciarrocchi
2007-10-16 2:19 ` Petr Baudis
2007-10-16 7:50 ` Matthieu Moy
2007-10-16 8:01 ` Paolo Ciarrocchi
2007-10-16 9:04 ` [PATCH] gitweb: Speed up get_projects_list for large source trees Luke Lu
2007-10-16 16:55 ` Andreas Ericsson
2007-10-16 23:20 ` Petr Baudis
2007-10-16 10:49 ` cogito and remote#branch, was Re: [PATCH] Git homepage: remove all the references to Cogito Johannes Schindelin
2007-10-16 21:09 ` remote#branch Jan Hudec
2007-10-16 21:35 ` remote#branch Johannes Schindelin
2007-10-27 20:47 ` remote#branch Jan Hudec
2007-10-27 23:01 ` remote#branch Johannes Schindelin
2007-10-29 17:40 ` remote#branch Jan Hudec
2007-10-29 18:17 ` remote#branch Linus Torvalds
2007-10-29 21:49 ` remote#branch Theodore Tso
2007-10-29 22:57 ` remote#branch Linus Torvalds
2007-10-29 23:49 ` remote#branch Johannes Schindelin
2007-10-30 3:01 ` remote#branch Theodore Tso
2007-10-30 3:40 ` remote#branch Junio C Hamano
2007-10-30 4:40 ` remote#branch Theodore Tso
2007-10-30 4:51 ` remote#branch Linus Torvalds
2007-10-30 5:37 ` remote#branch Tom Prince
2007-10-30 14:59 ` remote#branch Linus Torvalds
2007-10-30 16:02 ` remote#branch Tom Prince
2007-10-30 17:39 ` remote#branch Linus Torvalds
2007-10-30 17:49 ` remote#branch Matthieu Moy
2007-10-30 17:58 ` remote#branch Linus Torvalds
2007-10-30 18:19 ` remote#branch Linus Torvalds
2007-10-30 19:18 ` remote#branch Pascal Obry
2007-10-30 19:38 ` remote#branch Linus Torvalds
2007-10-30 20:15 ` remote#branch Randal L. Schwartz
2007-10-30 20:30 ` remote#branch Linus Torvalds
2007-10-30 20:36 ` remote#branch Nicolas Pitre
2007-10-30 23:58 ` remote#branch Jeff King
2007-10-31 0:12 ` remote#branch Jakub Narebski
2007-10-31 1:38 ` remote#branch Jeff King
2007-10-31 1:49 ` remote#branch Jakub Narebski
2007-10-31 1:57 ` remote#branch Jeff King
2007-10-31 7:09 ` remote#branch Andreas Ericsson
2007-10-31 8:35 ` remote#branch Mike Hommey
2007-10-31 9:03 ` remote#branch Andreas Ericsson
2007-10-31 9:15 ` remote#branch Mike Hommey
2007-11-01 0:22 ` remote#branch Jakub Narebski
2007-11-01 5:11 ` remote#branch Theodore Tso
2007-11-01 7:29 ` remote#branch Andreas Ericsson
2007-10-31 9:33 ` remote#branch Pascal Obry
2007-10-31 6:42 ` remote#branch David Kastrup
2007-10-31 15:28 ` remote#branch Linus Torvalds
2007-10-31 20:47 ` remote#branch Jeff King
2007-10-31 21:01 ` remote#branch Linus Torvalds
2007-10-31 21:26 ` Jeff King [this message]
2007-10-31 21:28 ` remote#branch Linus Torvalds
2007-10-31 21:07 ` remote#branch Andreas Ericsson
2007-10-31 21:31 ` remote#branch Jeff King
2007-10-31 6:39 ` remote#branch David Kastrup
2007-10-31 8:16 ` remote#branch Wincent Colaiuta
2007-10-31 8:25 ` remote#branch Robin Rosenberg
2007-10-31 9:34 ` remote#branch Pascal Obry
2007-10-31 17:13 ` remote#branch Petr Baudis
2007-10-30 19:15 ` remote#branch Pascal Obry
2007-10-30 19:36 ` remote#branch Jan Hudec
2007-10-30 19:53 ` remote#branch Linus Torvalds
2007-10-31 19:29 ` remote#branch Erik Warendorph
2007-10-30 10:02 ` remote#branch Johannes Schindelin
2007-10-31 0:41 ` remote#branch Martin Langhoff
2007-10-31 0:59 ` remote#branch Linus Torvalds
2007-10-31 1:43 ` remote#branch Jeff King
2007-10-31 1:49 ` remote#branch Martin Langhoff
2007-10-31 1:59 ` remote#branch Jeff King
2007-10-31 3:08 ` remote#branch Johannes Schindelin
2007-10-30 4:50 ` remote#branch Linus Torvalds
2007-10-29 18:32 ` remote#branch Johannes Schindelin
2007-10-16 22:16 ` cogito and remote#branch, was Re: [PATCH] Git homepage: remove all the references to Cogito Jonas Fonseca
2007-10-31 17:09 ` Petr Baudis
2007-10-31 21:17 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031212655.GB13823@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).