* [PATCH] builtin.h: remove declaration of cmd_rebase__helper
@ 2018-07-29 22:44 Ramsay Jones
2018-07-30 22:12 ` Alban Gruin
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2018-07-29 22:44 UTC (permalink / raw)
To: alban.gruin; +Cc: Junio C Hamano, GIT Mailing-list
Commit 94d4e2fb88 ("rebase -i: move rebase--helper modes to
rebase--interactive", 2018-07-24) removed the definition of the
'cmd_rebase__helper' symbol, but forgot to remove the corresponding
declaration in the 'builtin.h' header file.
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Alban,
If you need to re-roll your 'ag/rebase-i-in-c' branch, could you
please squash this into the relevant patch (commit 94d4e2fb88).
Thanks!
ATB,
Ramsay Jones
builtin.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin.h b/builtin.h
index aac8f5f340..6538932e99 100644
--- a/builtin.h
+++ b/builtin.h
@@ -206,7 +206,6 @@ extern int cmd_range_diff(int argc, const char **argv, const char *prefix);
extern int cmd_read_tree(int argc, const char **argv, const char *prefix);
extern int cmd_rebase(int argc, const char **argv, const char *prefix);
extern int cmd_rebase__interactive(int argc, const char **argv, const char *prefix);
-extern int cmd_rebase__helper(int argc, const char **argv, const char *prefix);
extern int cmd_receive_pack(int argc, const char **argv, const char *prefix);
extern int cmd_reflog(int argc, const char **argv, const char *prefix);
extern int cmd_remote(int argc, const char **argv, const char *prefix);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] builtin.h: remove declaration of cmd_rebase__helper
2018-07-29 22:44 [PATCH] builtin.h: remove declaration of cmd_rebase__helper Ramsay Jones
@ 2018-07-30 22:12 ` Alban Gruin
0 siblings, 0 replies; 2+ messages in thread
From: Alban Gruin @ 2018-07-30 22:12 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
Hi Ramsay,
Le 30/07/2018 à 00:44, Ramsay Jones a écrit :
>
> Commit 94d4e2fb88 ("rebase -i: move rebase--helper modes to
> rebase--interactive", 2018-07-24) removed the definition of the
> 'cmd_rebase__helper' symbol, but forgot to remove the corresponding
> declaration in the 'builtin.h' header file.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Alban,
>
> If you need to re-roll your 'ag/rebase-i-in-c' branch, could you
> please squash this into the relevant patch (commit 94d4e2fb88).
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> builtin.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builtin.h b/builtin.h
> index aac8f5f340..6538932e99 100644
> --- a/builtin.h
> +++ b/builtin.h
> @@ -206,7 +206,6 @@ extern int cmd_range_diff(int argc, const char **argv, const char *prefix);
> extern int cmd_read_tree(int argc, const char **argv, const char *prefix);
> extern int cmd_rebase(int argc, const char **argv, const char *prefix);
> extern int cmd_rebase__interactive(int argc, const char **argv, const char *prefix);
> -extern int cmd_rebase__helper(int argc, const char **argv, const char *prefix);
> extern int cmd_receive_pack(int argc, const char **argv, const char *prefix);
> extern int cmd_reflog(int argc, const char **argv, const char *prefix);
> extern int cmd_remote(int argc, const char **argv, const char *prefix);
>
Thank you for pointing this out! I will include it in my next reroll.
Cheers,
Alban
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-29 22:44 [PATCH] builtin.h: remove declaration of cmd_rebase__helper Ramsay Jones
2018-07-30 22:12 ` Alban Gruin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).