git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Alban Gruin <alban.gruin@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] builtin.h: remove declaration of cmd_rebase__helper
Date: Tue, 31 Jul 2018 00:12:07 +0200	[thread overview]
Message-ID: <dce8c99b-51e9-4ed1-8ae4-28049cb6e7ec@gmail.com> (raw)
In-Reply-To: <36bfb2da-f163-67b9-4ddd-398ce137f85f@ramsayjones.plus.com>

Hi Ramsay,

Le 30/07/2018 à 00:44, Ramsay Jones a écrit :
> 
> Commit 94d4e2fb88 ("rebase -i: move rebase--helper modes to
> rebase--interactive", 2018-07-24) removed the definition of the
> 'cmd_rebase__helper' symbol, but forgot to remove the corresponding
> declaration in the 'builtin.h' header file.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Alban,
> 
> If you need to re-roll your 'ag/rebase-i-in-c' branch, could you
> please squash this into the relevant patch (commit 94d4e2fb88).
> 
> Thanks!
> 
> ATB,
> Ramsay Jones
> 
>  builtin.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/builtin.h b/builtin.h
> index aac8f5f340..6538932e99 100644
> --- a/builtin.h
> +++ b/builtin.h
> @@ -206,7 +206,6 @@ extern int cmd_range_diff(int argc, const char **argv, const char *prefix);
>  extern int cmd_read_tree(int argc, const char **argv, const char *prefix);
>  extern int cmd_rebase(int argc, const char **argv, const char *prefix);
>  extern int cmd_rebase__interactive(int argc, const char **argv, const char *prefix);
> -extern int cmd_rebase__helper(int argc, const char **argv, const char *prefix);
>  extern int cmd_receive_pack(int argc, const char **argv, const char *prefix);
>  extern int cmd_reflog(int argc, const char **argv, const char *prefix);
>  extern int cmd_remote(int argc, const char **argv, const char *prefix);
> 

Thank you for pointing this out!  I will include it in my next reroll.

Cheers,
Alban


      reply	other threads:[~2018-07-30 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-29 22:44 [PATCH] builtin.h: remove declaration of cmd_rebase__helper Ramsay Jones
2018-07-30 22:12 ` Alban Gruin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dce8c99b-51e9-4ed1-8ae4-28049cb6e7ec@gmail.com \
    --to=alban.gruin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).