* [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
@ 2016-07-21 20:59 Johannes Sixt
2016-07-22 8:21 ` Johannes Schindelin
2016-07-22 19:31 ` [PATCH " Eric Wong
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Sixt @ 2016-07-21 20:59 UTC (permalink / raw)
To: Git Mailing List; +Cc: git-for-windows
The previous commit introduced the first use of ENOTSOCK. This macro is
not available on Windows. Define it as WSAENOTSOCK because that is the
corresponding error value reported by the Windows versions of socket
functions.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
compat/mingw.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 233933e..95e128f 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -73,6 +73,9 @@ typedef int pid_t;
#ifndef ECONNABORTED
#define ECONNABORTED WSAECONNABORTED
#endif
+#ifndef ENOTSOCK
+#define ENOTSOCK WSAENOTSOCK
+#endif
struct passwd {
char *pw_name;
--
2.9.0.443.ga8520ad
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
2016-07-21 20:59 [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK Johannes Sixt
@ 2016-07-22 8:21 ` Johannes Schindelin
2016-07-22 19:28 ` Junio C Hamano
2016-07-22 19:31 ` [PATCH " Eric Wong
1 sibling, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2016-07-22 8:21 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Git Mailing List, git-for-windows
Hi Hannes,
On Thu, 21 Jul 2016, Johannes Sixt wrote:
> The previous commit introduced the first use of ENOTSOCK. This macro is
> not available on Windows. Define it as WSAENOTSOCK because that is the
> corresponding error value reported by the Windows versions of socket
> functions.
Thanks for catching this early.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
2016-07-22 8:21 ` Johannes Schindelin
@ 2016-07-22 19:28 ` Junio C Hamano
2016-07-23 8:02 ` Johannes Schindelin
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2016-07-22 19:28 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Johannes Sixt, Git Mailing List, git-for-windows
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi Hannes,
>
> On Thu, 21 Jul 2016, Johannes Sixt wrote:
>
>> The previous commit introduced the first use of ENOTSOCK. This macro is
>> not available on Windows. Define it as WSAENOTSOCK because that is the
>> corresponding error value reported by the Windows versions of socket
>> functions.
>
> Thanks for catching this early.
(is that an acked/reviewed-by? it is OK if it is not).
Yeah, thanks, both.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
2016-07-21 20:59 [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK Johannes Sixt
2016-07-22 8:21 ` Johannes Schindelin
@ 2016-07-22 19:31 ` Eric Wong
1 sibling, 0 replies; 6+ messages in thread
From: Eric Wong @ 2016-07-22 19:31 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Git Mailing List, git-for-windows
Johannes Sixt <j6t@kdbg.org> wrote:
> The previous commit introduced the first use of ENOTSOCK. This macro is
> not available on Windows. Define it as WSAENOTSOCK because that is the
> corresponding error value reported by the Windows versions of socket
> functions.
Thanks. I thought compat/poll/poll.c already used ENOTSOCK
but I was mislead by the #ifdefs :x
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
2016-07-22 19:28 ` Junio C Hamano
@ 2016-07-23 8:02 ` Johannes Schindelin
2016-07-23 8:39 ` [PATCH v2 " Johannes Sixt
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2016-07-23 8:02 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Johannes Sixt, Git Mailing List, git-for-windows
Hi Junio,
On Fri, 22 Jul 2016, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Thu, 21 Jul 2016, Johannes Sixt wrote:
> >
> >> The previous commit introduced the first use of ENOTSOCK. This macro is
> >> not available on Windows. Define it as WSAENOTSOCK because that is the
> >> corresponding error value reported by the Windows versions of socket
> >> functions.
> >
> > Thanks for catching this early.
>
> (is that an acked/reviewed-by? it is OK if it is not).
It had been neither, as I had only looked at the patch briefly (which I
deem not enough to account for a review).
However, I now reviewed it properly and offer my Acked-by:.
If it is not too much to ask, I would love to have the following added to
the commit message:
For details, see
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476.aspx
Thanks,
Dscho
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
2016-07-23 8:02 ` Johannes Schindelin
@ 2016-07-23 8:39 ` Johannes Sixt
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Sixt @ 2016-07-23 8:39 UTC (permalink / raw)
To: Johannes Schindelin, Junio C Hamano; +Cc: Git Mailing List, git-for-windows
The previous commit introduced the first use of ENOTSOCK. This macro is
not available on Windows. Define it as WSAENOTSOCK because that is the
corresponding error value reported by the Windows versions of socket
functions.
For details, see
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476.aspx
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
Same patch text, but the commit message is amended, just in case it's
easier for you to apply a new patch than to amend a queued one.
Thanks everybody.
compat/mingw.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 233933e..95e128f 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -73,6 +73,9 @@ typedef int pid_t;
#ifndef ECONNABORTED
#define ECONNABORTED WSAECONNABORTED
#endif
+#ifndef ENOTSOCK
+#define ENOTSOCK WSAENOTSOCK
+#endif
struct passwd {
char *pw_name;
--
2.9.0.443.ga8520ad
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-23 8:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-21 20:59 [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK Johannes Sixt
2016-07-22 8:21 ` Johannes Schindelin
2016-07-22 19:28 ` Junio C Hamano
2016-07-23 8:02 ` Johannes Schindelin
2016-07-23 8:39 ` [PATCH v2 " Johannes Sixt
2016-07-22 19:31 ` [PATCH " Eric Wong
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).