From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
Git Mailing List <git@vger.kernel.org>,
git-for-windows <git-for-windows@googlegroups.com>
Subject: Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
Date: Sat, 23 Jul 2016 10:02:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607230957320.14111@virtualbox> (raw)
In-Reply-To: <xmqqmvl9a2wc.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Fri, 22 Jul 2016, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Thu, 21 Jul 2016, Johannes Sixt wrote:
> >
> >> The previous commit introduced the first use of ENOTSOCK. This macro is
> >> not available on Windows. Define it as WSAENOTSOCK because that is the
> >> corresponding error value reported by the Windows versions of socket
> >> functions.
> >
> > Thanks for catching this early.
>
> (is that an acked/reviewed-by? it is OK if it is not).
It had been neither, as I had only looked at the patch briefly (which I
deem not enough to account for a review).
However, I now reviewed it properly and offer my Acked-by:.
If it is not too much to ask, I would love to have the following added to
the commit message:
For details, see
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476.aspx
Thanks,
Dscho
next prev parent reply other threads:[~2016-07-23 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 20:59 [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK Johannes Sixt
2016-07-22 8:21 ` Johannes Schindelin
2016-07-22 19:28 ` Junio C Hamano
2016-07-23 8:02 ` Johannes Schindelin [this message]
2016-07-23 8:39 ` [PATCH v2 " Johannes Sixt
2016-07-22 19:31 ` [PATCH " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607230957320.14111@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).