From: Jeff King <peff@peff.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: "Michael Strawbridge" <michael.strawbridge@amd.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [REGRESSION] uninitialized value $address in git send-email when given multiple recipients separated by commas
Date: Sat, 23 Sep 2023 23:36:25 -0400 [thread overview]
Message-ID: <20230924033625.GA1492190@coredump.intra.peff.net> (raw)
In-Reply-To: <ZQ1eGzqfyoeeTBUq@debian.me>
On Fri, Sep 22, 2023 at 04:27:55PM +0700, Bagas Sanjaya wrote:
> To reproduce this regression:
I couldn't reproduce the problem here.
I had to modify your instructions slightly:
> 1. Clone git.git repo, then branch off:
>
> ```
> $ git clone https://github.com/git/git.git && cd git
> $ git checkout -b test
> ```
>
> 2. Make two dummy signed-off commits:
>
> ```
> $ echo test > test && git add test && git commit -s -m "test"
> $ echo "test test" >> test && git commit -a -s -m "test test"
> ```
This all worked.
> 3. Generate patch series:
>
> ```
> $ mkdir /tmp/test
> $ git format-patch -o /tmp/test --cover-letter main
> ```
This should be s/main/master/, since the git.git repo from step 1 does
not have a "main" branch.
> 4. Send the series to dummy address:
>
> ```
> $ git send-email --to="foo <foo@acme.com>,bar <bar@acme.com>" /tmp/test/*.patch
> ```
This did not produce an error for me. I switched out acme.com for some
addresses I control, and confirmed that the mail was all delivered fine.
Your report also mentions a validation hook, so I tried installing one
like:
cat >.git/hooks/sendemail-validate <<-\EOF
#!/bin/sh
echo >&2 running validate hook
exit 0
EOF
chmod +x .git/hooks/sendemail-validate
and confirmed that the hook runs (three times, as expected). But still
no error. I'm using v2.41.0 to test against.
-Peff
next prev parent reply other threads:[~2023-09-24 3:36 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 9:27 [REGRESSION] uninitialized value $address in git send-email when given multiple recipients separated by commas Bagas Sanjaya
2023-09-24 3:36 ` Jeff King [this message]
2023-09-25 7:45 ` Bagas Sanjaya
2023-09-25 8:00 ` Jeff King
2023-09-25 14:48 ` Todd Zullinger
2023-09-25 16:17 ` Jeff King
2023-10-11 13:41 ` Bagas Sanjaya
2023-10-11 19:27 ` Michael Strawbridge
2023-10-11 20:22 ` [PATCH] send-email: move process_address_list earlier to avoid, uninitialized address error Michael Strawbridge
2023-10-11 20:25 ` Michael Strawbridge
2023-10-11 21:27 ` Junio C Hamano
2023-10-11 22:18 ` Jeff King
2023-10-11 22:37 ` Junio C Hamano
2023-10-11 22:47 ` Jeff King
2023-10-13 20:25 ` Michael Strawbridge
2023-10-20 6:45 ` Jeff King
2023-10-20 7:14 ` Jeff King
2023-10-20 10:03 ` [PATCH 0/3] some send-email --compose fixes Jeff King
2023-10-20 10:09 ` [PATCH 1/3] doc/send-email: mention handling of "reply-to" with --compose Jeff King
2023-10-20 10:13 ` [PATCH 2/3] Revert "send-email: extract email-parsing code into a subroutine" Jeff King
2023-10-20 10:45 ` Oswald Buddenhagen
2023-10-23 18:40 ` Jeff King
2023-10-23 19:50 ` Oswald Buddenhagen
2023-10-25 6:11 ` Jeff King
2023-10-25 9:23 ` Oswald Buddenhagen
2023-10-27 22:31 ` Junio C Hamano
2023-10-30 9:13 ` Jeff King
2023-10-20 21:45 ` Junio C Hamano
2023-10-23 18:47 ` Jeff King
2023-10-20 10:15 ` [PATCH 3/3] send-email: handle to/cc/bcc from --compose message Jeff King
2023-10-20 17:30 ` Eric Sunshine
2023-10-20 21:42 ` [PATCH 0/3] some send-email --compose fixes Junio C Hamano
2023-10-23 18:51 ` Jeff King
2023-10-24 20:12 ` Michael Strawbridge
2023-10-24 20:19 ` [PATCH] send-email: move validation code below process_address_list Michael Strawbridge
2023-10-24 21:55 ` Junio C Hamano
2023-10-24 22:03 ` Junio C Hamano
2023-10-25 18:48 ` Michael Strawbridge
2023-10-25 18:51 ` [PATCH v2] " Michael Strawbridge
2023-10-26 12:44 ` Junio C Hamano
2023-10-26 13:11 ` Michael Strawbridge
2023-10-25 6:50 ` [PATCH] " Jeff King
2023-10-25 18:47 ` Michael Strawbridge
2023-10-25 7:43 ` Uwe Kleine-König
2023-10-27 13:04 ` Junio C Hamano
2023-10-20 2:50 ` [PATCH] send-email: move process_address_list earlier to avoid, uninitialized address error Bagas Sanjaya
2023-09-26 11:33 ` [REGRESSION] uninitialized value $address in git send-email when given multiple recipients separated by commas Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230924033625.GA1492190@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luben.tuikov@amd.com \
--cc=me@ttaylorr.com \
--cc=michael.strawbridge@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).