From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Emily Shaffer <emilyshaffer@google.com>
Subject: Re: What's cooking in git.git (Aug 2021, #02; Tue, 3)
Date: Wed, 4 Aug 2021 20:06:58 +0200 [thread overview]
Message-ID: <20210804180658.GG23408@szeder.dev> (raw)
In-Reply-To: <87wnp1mqv2.fsf@evledraar.gmail.com>
On Wed, Aug 04, 2021 at 12:22:44PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > * ab/progress-users-adjust-counters (2021-07-23) 3 commits
> > - entry: show finer-grained counter in "Filtering content" progress line
> > - midx: don't provide a total for QSORT() progress
> > - commit-graph: fix bogus counter in "Scanning merged commits" progress line
> >
> > The code to show progress indicator in a few codepaths did not
> > cover between 0-100%, which has been corrected.
> >
> > Waiting for a clarification.
> > cf. <xmqqbl6slmer.fsf@gitster.g>
>
> I think that what SZEDER had to say in
> https://lore.kernel.org/git/20210802220506.GF23408@szeder.dev/ should be
> enough to clear this to proceed forward.
Note that I also pointed out errors in the commit messages that should
be addressed before this patch series advances; see:
https://public-inbox.org/git/20210802210759.GD23408@szeder.dev/
https://public-inbox.org/git/20210802214827.GE23408@szeder.dev/
But none of these patches fixes regressions introduced in this release
cycle, so it's not urgent.
> I.e. this topic is missing his subsequent
> https://lore.kernel.org/git/20210620200303.2328957-7-szeder.dev@gmail.com/
> patch.
>
> But as he notes we only encounter this in one of our tests (and are
> unlikely to in the wild).
>
> Between this topic and my ab/only-single-progress-at-once I think we're
> better off getting those basic fixes in before proceeding with any
> tricky additions of BUG() and other assertions, per what I noted in
> https://public-inbox.org/git/cover-00.25-00000000000-20210623T155626Z-avarab@gmail.com/;
> i.e. that some of those assertions were themselves buggy.
next prev parent reply other threads:[~2021-08-04 18:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 7:03 What's cooking in git.git (Aug 2021, #02; Tue, 3) Junio C Hamano
2021-08-04 10:22 ` Ævar Arnfjörð Bjarmason
2021-08-04 17:57 ` Junio C Hamano
2021-08-04 20:06 ` Ævar Arnfjörð Bjarmason
2021-08-04 18:06 ` Junio C Hamano
2021-08-04 19:53 ` Ævar Arnfjörð Bjarmason
2021-08-04 20:10 ` Junio C Hamano
2021-08-04 21:28 ` SZEDER Gábor
2021-08-04 21:36 ` SZEDER Gábor
2021-08-04 23:06 ` Ævar Arnfjörð Bjarmason
2021-08-05 2:08 ` Junio C Hamano
2021-08-05 2:53 ` Ævar Arnfjörð Bjarmason
2021-08-30 21:03 ` SZEDER Gábor
2021-08-04 18:06 ` SZEDER Gábor [this message]
2021-08-04 14:22 ` Derrick Stolee
2021-08-04 21:03 ` Jeff King
2021-08-05 9:55 ` Phillip Wood
2021-08-05 1:37 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804180658.GG23408@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).