From: Phillip Wood <phillip.wood123@gmail.com>
To: Derrick Stolee <stolee@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Cc: "Lénaïc Huard" <lenaic@lhuard.fr>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: What's cooking in git.git (Aug 2021, #02; Tue, 3)
Date: Thu, 5 Aug 2021 10:55:56 +0100 [thread overview]
Message-ID: <1a3e2551-a6b3-2628-f21f-f9281e581871@gmail.com> (raw)
In-Reply-To: <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>
On 04/08/2021 15:22, Derrick Stolee wrote:
> On 8/4/2021 3:03 AM, Junio C Hamano wrote:
> ...
>> --------------------------------------------------
>> [Stalled]
> ...
>> * lh/systemd-timers (2021-07-02) 3 commits
>> - maintenance: add support for systemd timers on Linux
>> - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>> - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>>
>> "git maintenance" scheduler learned to use systemd timers as a
>> possible backend.
>>
>> Waiting for reviews.
>
> I just took another look at this series and see that there were a few
> items that have yet to be addressed. CC'ing Lénaïc and reviewers to
> see if those items will come in a v8. Here is a quick summary of my
> understanding:
>
> * There are some non-ASCII characters in a code comment that are a
> bit non-standard and could be replaced with ASCII representations.
> (nit, but if re-rolling already this might be worth doing.)
>
> * There is some discussion about using string_list_split() instead
> of hand-rolling a string splitter. Discussion decided that we
> should _not_ use strbuf_split_buf(). It would be nice to later
> create a version of strvec_split() that takes an arbitrary
> delimiter, but isn't necessary for this series.
>
> * There was some discussion about using #ifdef to make certain
> logic be compiled in or not. This seems (to me) less important
> in the case of returning 0 or 1, but in the third patch there
> is a large set of logic that is only compiled on Linux, which
> seems like it should match the pattern of the other methods,
> if possible.
>
> Again, this is just my drive-by summary, but hopefully it renews
> work on this topic.
I think that is a fair summary, I'd be happy to see us take this series
as-is, the code is fine and any small warts could be cleaned up in the
future. I think Eric expressed a similar opinion in [1]. Lénaïc has been
responsive to fixing bugs as well as taking on board other comments, I
think we've reached the stage where it is not reasonable to keep asking
for small changes.
Best Wishes
Phillip
[1]
https://lore.kernel.org/git/CAPig+cT-x4_YuxmmoFw62jFqKRFJrS_UkyNOkdQz9-Gwec3QCQ@mail.gmail.com
> Thanks,
> -Stolee
>
next prev parent reply other threads:[~2021-08-05 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 7:03 What's cooking in git.git (Aug 2021, #02; Tue, 3) Junio C Hamano
2021-08-04 10:22 ` Ævar Arnfjörð Bjarmason
2021-08-04 17:57 ` Junio C Hamano
2021-08-04 20:06 ` Ævar Arnfjörð Bjarmason
2021-08-04 18:06 ` Junio C Hamano
2021-08-04 19:53 ` Ævar Arnfjörð Bjarmason
2021-08-04 20:10 ` Junio C Hamano
2021-08-04 21:28 ` SZEDER Gábor
2021-08-04 21:36 ` SZEDER Gábor
2021-08-04 23:06 ` Ævar Arnfjörð Bjarmason
2021-08-05 2:08 ` Junio C Hamano
2021-08-05 2:53 ` Ævar Arnfjörð Bjarmason
2021-08-30 21:03 ` SZEDER Gábor
2021-08-04 18:06 ` SZEDER Gábor
2021-08-04 14:22 ` Derrick Stolee
2021-08-04 21:03 ` Jeff King
2021-08-05 9:55 ` Phillip Wood [this message]
2021-08-05 1:37 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a3e2551-a6b3-2628-f21f-f9281e581871@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lenaic@lhuard.fr \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).