From: Paul Mackerras <paulus@ozlabs.org>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] gitk: replace tabs with spaces
Date: Sat, 3 Oct 2020 19:14:19 +1000 [thread overview]
Message-ID: <20201003091419.GB3089868@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <ecdede5cf50bdb966f53bcf5171c80b5f8959d4b.1599798976.git.liu.denton@gmail.com>
On Thu, Sep 10, 2020 at 09:36:33PM -0700, Denton Liu wrote:
> The source code is a mix of tabs and spaces. The indentation style
> currently is four spaces per indent level but uses tabs every other
> level (at eight spaces). Fix this inconsistent spacing and tabbing by
> just using a space-indent for everything.
>
> This was done mechanically by running:
>
> $ expand -i gitk >gitk.new
> $ mv gitk.new gitk
>
> This patch should be empty with `--ignore-all-space`.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
Thanks, applied, though in fact I regenerated the patch since I had
some local commits that I had not yet pushed out.
Paul.
next prev parent reply other threads:[~2020-10-03 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 8:27 [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10 8:27 ` [PATCH 1/2] gitk: replace spaces with tabs Denton Liu
2020-09-10 8:27 ` [PATCH 2/2] gitk: manually fix whitespace errors Denton Liu
2020-09-10 8:36 ` [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10 9:17 ` Paul Mackerras
2020-09-11 4:36 ` [PATCH v2 " Denton Liu
2020-09-11 4:36 ` [PATCH v2 1/2] gitk: replace tabs with spaces Denton Liu
2020-10-03 9:14 ` Paul Mackerras [this message]
2020-09-11 4:36 ` [PATCH v2 2/2] gitk: replace commented tab with space Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003091419.GB3089868@thinks.paulus.ozlabs.org \
--to=paulus@ozlabs.org \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).