list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Paul Mackerras <>
To: Denton Liu <>
Cc: Git Mailing List <>
Subject: Re: [PATCH v2 1/2] gitk: replace tabs with spaces
Date: Sat, 3 Oct 2020 19:14:19 +1000
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Sep 10, 2020 at 09:36:33PM -0700, Denton Liu wrote:
> The source code is a mix of tabs and spaces. The indentation style
> currently is four spaces per indent level but uses tabs every other
> level (at eight spaces). Fix this inconsistent spacing and tabbing by
> just using a space-indent for everything.
> This was done mechanically by running:
> 	$ expand -i gitk >
> 	$ mv gitk
> This patch should be empty with `--ignore-all-space`.
> Signed-off-by: Denton Liu <>

Thanks, applied, though in fact I regenerated the patch since I had
some local commits that I had not yet pushed out.


  reply	other threads:[~2020-10-03  9:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  8:27 [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10  8:27 ` [PATCH 1/2] gitk: replace spaces with tabs Denton Liu
2020-09-10  8:27 ` [PATCH 2/2] gitk: manually fix whitespace errors Denton Liu
2020-09-10  8:36 ` [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10  9:17 ` Paul Mackerras
2020-09-11  4:36 ` [PATCH v2 " Denton Liu
2020-09-11  4:36   ` [PATCH v2 1/2] gitk: replace tabs with spaces Denton Liu
2020-10-03  9:14     ` Paul Mackerras [this message]
2020-09-11  4:36   ` [PATCH v2 2/2] gitk: replace commented tab with space Denton Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone