git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation
Date: Thu, 10 Sep 2020 19:17:19 +1000	[thread overview]
Message-ID: <20200910091719.GB2537966@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <cover.1599726439.git.liu.denton@gmail.com>

On Thu, Sep 10, 2020 at 01:27:40AM -0700, Denton Liu wrote:
> The source code of gitk has some funny indentation. It uses four spaces
> per level indent but uses tabs every other level (eight spaces).
> Reindent gitk to just use tabs instead.

I don't think I want to do this.  I would accept changing all the
indentation to use just spaces - at least that's going to look OK
regardless of the tab width setting.

Paul.

  parent reply	other threads:[~2020-09-10  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  8:27 [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10  8:27 ` [PATCH 1/2] gitk: replace spaces with tabs Denton Liu
2020-09-10  8:27 ` [PATCH 2/2] gitk: manually fix whitespace errors Denton Liu
2020-09-10  8:36 ` [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10  9:17 ` Paul Mackerras [this message]
2020-09-11  4:36 ` [PATCH v2 " Denton Liu
2020-09-11  4:36   ` [PATCH v2 1/2] gitk: replace tabs with spaces Denton Liu
2020-10-03  9:14     ` Paul Mackerras
2020-09-11  4:36   ` [PATCH v2 2/2] gitk: replace commented tab with space Denton Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910091719.GB2537966@thinks.paulus.ozlabs.org \
    --to=paulus@ozlabs.org \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).