git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
	Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation
Date: Thu, 10 Sep 2020 01:36:15 -0700	[thread overview]
Message-ID: <20200910083615.GA1407716@generichostname> (raw)
In-Reply-To: <cover.1599726439.git.liu.denton@gmail.com>

On Thu, Sep 10, 2020 at 01:27:40AM -0700, Denton Liu wrote:
> Denton Liu (2):
>   gitk: replace spaces with tabs

Unfortunately, the patch is too big to be sent by email. It can be
retrieved from https://github.com/Denton-L/git.git
submitted/gitk-whitespace~.

If you don't want to pull it, the commit without the body is included
below. It can be fully reproduced by running the vim commands listed on
the gitk file.

-- >8 --

From: Denton Liu <liu.denton@gmail.com>
Date: Wed, 9 Sep 2020 12:10:51 -0700
Subject: [PATCH 1/2] gitk: replace spaces with tabs
To: Git Mailing List <git@vger.kernel.org>,
    Paul Mackerras <paulus@ozlabs.org>

The source code is a mix of tabs and spaces. The indentation style
currently is four spaces per indent level but uses tabs every other
level (at eight spaces). Fix this inconsistent spacing and tabbing by
just using a tab-indent for everything.

This was done mechanically using the following vim commands:

	:set tabstop=8
	:set expandtab
	:retab
	:set tabstop=4
	:set noexpandtab
	:retab!
	:set tabstop=8

A future commit will manually clean up the code style errors introduced
by this patch.

This patch should be empty with `--ignore-all-space`.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 gitk | 20408 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 10204 insertions(+), 10204 deletions(-)

  parent reply	other threads:[~2020-09-10  8:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  8:27 [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Denton Liu
2020-09-10  8:27 ` [PATCH 1/2] gitk: replace spaces with tabs Denton Liu
2020-09-10  8:27 ` [PATCH 2/2] gitk: manually fix whitespace errors Denton Liu
2020-09-10  8:36 ` Denton Liu [this message]
2020-09-10  9:17 ` [PATCH 0/2] gitk: fix mix of tabs and spaces in indentation Paul Mackerras
2020-09-11  4:36 ` [PATCH v2 " Denton Liu
2020-09-11  4:36   ` [PATCH v2 1/2] gitk: replace tabs with spaces Denton Liu
2020-10-03  9:14     ` Paul Mackerras
2020-09-11  4:36   ` [PATCH v2 2/2] gitk: replace commented tab with space Denton Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910083615.GA1407716@generichostname \
    --to=liu.denton@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).