From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Dennis Clarke <dclarke@blastwave.org>, git@vger.kernel.org
Subject: Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
Date: Wed, 22 Apr 2020 04:09:50 -0400 [thread overview]
Message-ID: <20200422080950.GA464427@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqzhb8rqa6.fsf@gitster.c.googlers.com>
On Sat, Apr 18, 2020 at 10:35:45PM -0700, Junio C Hamano wrote:
> Dennis Clarke <dclarke@blastwave.org> writes:
>
> > Very minor patch required :
>
> But both size_t and unsigned int are wrong types, no? Shouldn't we
> be using socklen_t (and we seem to have autoconf support to figure
> out an appropriate socklen_t fallback typedef)?
That is generally the right type according to POSIX, but I think there's
something even more subtle going on. If we're defining our own
inet_ntop(), then the type shouldn't really matter, should it?
Dennis didn't show us the compiler errors, but my suspicion is that it
is complaining because it is seeing the definition of inet_ntop()
already from a system header, and ours does not match.
Which implies that NO_INET_NTOP should not be set in the first place.
I think this is the same issue discussed in:
https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/
with a patch (which needs at least a signoff added) in:
https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/
Dennis, does building with:
make NO_INET_NTOP= NO_INET_PTON=
help?
-Peff
next prev parent reply other threads:[~2020-04-22 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 4:52 minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio Dennis Clarke
2020-04-19 5:35 ` Junio C Hamano
2020-04-22 8:09 ` Jeff King [this message]
2020-04-22 8:11 ` Jeff King
2020-04-23 0:09 ` Dennis Clarke
2020-04-23 5:41 ` Kevin Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422080950.GA464427@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=dclarke@blastwave.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).