From: Junio C Hamano <gitster@pobox.com>
To: Dennis Clarke <dclarke@blastwave.org>
Cc: git@vger.kernel.org
Subject: Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
Date: Sat, 18 Apr 2020 22:35:45 -0700 [thread overview]
Message-ID: <xmqqzhb8rqa6.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <6bf94982-71c4-78e9-0f4d-7fa4e485c417@blastwave.org> (Dennis Clarke's message of "Sun, 19 Apr 2020 04:52:20 +0000")
Dennis Clarke <dclarke@blastwave.org> writes:
> Very minor patch required :
But both size_t and unsigned int are wrong types, no? Shouldn't we
be using socklen_t (and we seem to have autoconf support to figure
out an appropriate socklen_t fallback typedef)?
> --- ./compat/inet_ntop.c.orig Tue Apr 14 01:51:03 2020
> +++ ./compat/inet_ntop.c Sun Apr 19 04:16:39 2020
> @@ -168,7 +168,7 @@
> * Paul Vixie, 1996.
> */
> const char *
> -inet_ntop(int af, const void *src, char *dst, size_t size)
> +inet_ntop(int af, const void *src, char *dst, unsigned int size)
> {
> switch (af) {
> case AF_INET:
> --- ./git-compat-util.h.orig Tue Apr 14 01:51:03 2020
> +++ ./git-compat-util.h Sun Apr 19 03:56:17 2020
> @@ -795,7 +795,7 @@
> #endif
>
> #ifdef NO_INET_NTOP
> -const char *inet_ntop(int af, const void *src, char *dst, size_t size);
> +const char *inet_ntop(int af, const void *src, char *dst, unsigned
> int size);
> #endif
>
> #ifdef NO_PTHREADS
> #
> # exit
>
> That allows compile to proceed beatly with :
>
> alpha$
> alpha$ cc -V
> cc: Studio 12.6 Sun C 5.15 SunOS_sparc 2017/05/30
next prev parent reply other threads:[~2020-04-19 5:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 4:52 minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio Dennis Clarke
2020-04-19 5:35 ` Junio C Hamano [this message]
2020-04-22 8:09 ` Jeff King
2020-04-22 8:11 ` Jeff King
2020-04-23 0:09 ` Dennis Clarke
2020-04-23 5:41 ` Kevin Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhb8rqa6.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dclarke@blastwave.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).