From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 904D11F9E0 for ; Wed, 22 Apr 2020 08:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbgDVIJy (ORCPT ); Wed, 22 Apr 2020 04:09:54 -0400 Received: from cloud.peff.net ([104.130.231.41]:35566 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726539AbgDVIJv (ORCPT ); Wed, 22 Apr 2020 04:09:51 -0400 Received: (qmail 4391 invoked by uid 109); 22 Apr 2020 08:09:51 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Wed, 22 Apr 2020 08:09:51 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 27356 invoked by uid 111); 22 Apr 2020 08:20:56 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 22 Apr 2020 04:20:56 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 22 Apr 2020 04:09:50 -0400 From: Jeff King To: Junio C Hamano Cc: Dennis Clarke , git@vger.kernel.org Subject: Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio Message-ID: <20200422080950.GA464427@coredump.intra.peff.net> References: <6bf94982-71c4-78e9-0f4d-7fa4e485c417@blastwave.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Apr 18, 2020 at 10:35:45PM -0700, Junio C Hamano wrote: > Dennis Clarke writes: > > > Very minor patch required : > > But both size_t and unsigned int are wrong types, no? Shouldn't we > be using socklen_t (and we seem to have autoconf support to figure > out an appropriate socklen_t fallback typedef)? That is generally the right type according to POSIX, but I think there's something even more subtle going on. If we're defining our own inet_ntop(), then the type shouldn't really matter, should it? Dennis didn't show us the compiler errors, but my suspicion is that it is complaining because it is seeing the definition of inet_ntop() already from a system header, and ours does not match. Which implies that NO_INET_NTOP should not be set in the first place. I think this is the same issue discussed in: https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/ with a patch (which needs at least a signoff added) in: https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/ Dennis, does building with: make NO_INET_NTOP= NO_INET_PTON= help? -Peff