From: "SZEDER Gábor" <email@example.com> To: Junio C Hamano <firstname.lastname@example.org> Cc: Derrick Stolee <email@example.com>, Brandon Williams <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end Date: Fri, 2 Aug 2019 12:09:56 +0200 [thread overview] Message-ID: <20190802100956.GV20404@szeder.dev> (raw) In-Reply-To: <firstname.lastname@example.org> On Thu, Aug 01, 2019 at 11:18:42AM -0700, Junio C Hamano wrote: > SZEDER Gábor <email@example.com> writes: > > > On Thu, Aug 01, 2019 at 05:53:09PM +0200, SZEDER Gábor wrote: > >> Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific > >> tests at the end > > > > This subject line kind of sucks, doesn't it?! > > > > Alas I had a bit of a hard time coming up with something better. So > > far the best (well, least bad) I could think of is: > > > > t: warn against adding non-httpd-specific tests after sourcing 'lib-httpd' > > That reads well. Ok. Should I resend, or will you amend? (I see that 'pu' contains the old subject line). > Thanks. It must have been tedious to make sure moving tests around > won't break them due to some (hidden) inter-dependency among them. > Very much appreciated. Luckily, all the moved non-httpd tests and all the httpd tests in 't5510' and 't5703' work in their own directories, meaning that they neither influence other tests nor are influenced by other tests, with the exception of that $LOCAL_PRISTINE directory that I noted in the commit message of patch 2. I did actually diff-ed the output of the involved tests before and after these patches, and they were essentially identical (the only differences were that extra 'rm -rf', a couple of different timestamps, different commit oids shown by 'git commit' or 'git fetch', and the occasional races between the trace output and actual command output).
next prev parent reply other threads:[~2019-08-02 10:10 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-18 20:25 [PATCH 0/3] fetch: add --[no-]show-forced-updates Derrick Stolee via GitGitGadget 2019-06-18 20:25 ` [PATCH 1/3] fetch: add --[no-]show-forced-updates argument Derrick Stolee via GitGitGadget 2019-07-30 21:29 ` [PATCH] t5510-fetch: fix negated 'test_i18ngrep' invocation SZEDER Gábor 2019-07-30 21:40 ` SZEDER Gábor 2019-07-31 10:35 ` Derrick Stolee 2019-08-01 15:53 ` [PATCH 0/3] tests: run non-httpd-specific tests before sourcing 'lib-httpd.sh' SZEDER Gábor 2019-08-01 15:53 ` [PATCH 1/3] t5510-fetch: run non-httpd-specific test " SZEDER Gábor 2019-08-01 17:51 ` Derrick Stolee 2019-08-01 15:53 ` [PATCH 2/3] t5703: run all non-httpd-specific tests " SZEDER Gábor 2019-08-01 15:53 ` [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end SZEDER Gábor 2019-08-01 17:41 ` SZEDER Gábor 2019-08-01 18:18 ` Junio C Hamano 2019-08-02 10:09 ` SZEDER Gábor [this message] 2019-08-02 16:37 ` Junio C Hamano 2019-06-18 20:25 ` [PATCH 2/3] fetch: warn about forced updates in branch listing Derrick Stolee via GitGitGadget 2019-06-18 20:25 ` [PATCH 3/3] pull: add --[no-]show-forced-updates passthrough Derrick Stolee via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190802100956.GV20404@szeder.dev \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).