From: "SZEDER Gábor" <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: Derrick Stolee <firstname.lastname@example.org>, Brandon Williams <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end Date: Thu, 1 Aug 2019 19:41:26 +0200 [thread overview] Message-ID: <20190801174126.GU20404@szeder.dev> (raw) In-Reply-To: <email@example.com> On Thu, Aug 01, 2019 at 05:53:09PM +0200, SZEDER Gábor wrote: > Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific > tests at the end This subject line kind of sucks, doesn't it?! Alas I had a bit of a hard time coming up with something better. So far the best (well, least bad) I could think of is: t: warn against adding non-httpd-specific tests after sourcing 'lib-httpd' > We have a couple of test scripts that are not completely > httpd-specific, but do run a few httpd-specific tests at the end. > These test scripts source 'lib-httpd.sh' somewhere mid-script, which > then skips all the rest of the test script if the dependencies for > running httpd tests are not fulfilled. > > As the previous two patches in this series show, already on two > occasions non-httpd-specific tests were appended at the end of such > test scripts, and, consequently, they were skipped as well when httpd > tests couldn't be run. > > Add a comment at the end of these test scripts to warn against adding > non-httpd-specific tests at the end, in the hope that they will help > prevent similar issues in the future.
next prev parent reply other threads:[~2019-08-01 17:41 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-18 20:25 [PATCH 0/3] fetch: add --[no-]show-forced-updates Derrick Stolee via GitGitGadget 2019-06-18 20:25 ` [PATCH 1/3] fetch: add --[no-]show-forced-updates argument Derrick Stolee via GitGitGadget 2019-07-30 21:29 ` [PATCH] t5510-fetch: fix negated 'test_i18ngrep' invocation SZEDER Gábor 2019-07-30 21:40 ` SZEDER Gábor 2019-07-31 10:35 ` Derrick Stolee 2019-08-01 15:53 ` [PATCH 0/3] tests: run non-httpd-specific tests before sourcing 'lib-httpd.sh' SZEDER Gábor 2019-08-01 15:53 ` [PATCH 1/3] t5510-fetch: run non-httpd-specific test " SZEDER Gábor 2019-08-01 17:51 ` Derrick Stolee 2019-08-01 15:53 ` [PATCH 2/3] t5703: run all non-httpd-specific tests " SZEDER Gábor 2019-08-01 15:53 ` [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end SZEDER Gábor 2019-08-01 17:41 ` SZEDER Gábor [this message] 2019-08-01 18:18 ` Junio C Hamano 2019-08-02 10:09 ` SZEDER Gábor 2019-08-02 16:37 ` Junio C Hamano 2019-06-18 20:25 ` [PATCH 2/3] fetch: warn about forced updates in branch listing Derrick Stolee via GitGitGadget 2019-06-18 20:25 ` [PATCH 3/3] pull: add --[no-]show-forced-updates passthrough Derrick Stolee via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190801174126.GU20404@szeder.dev \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).