From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Derrick Stolee" <dstolee@microsoft.com>,
"Brandon Williams" <bwilliams.eng@gmail.com>,
git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: [PATCH 0/3] tests: run non-httpd-specific tests before sourcing 'lib-httpd.sh'
Date: Thu, 1 Aug 2019 17:53:06 +0200 [thread overview]
Message-ID: <20190801155309.15276-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20190730214000.GT20404@szeder.dev>
> Hrm... It looks like there is nothing httpd-specific in this test
> case, at all, so we could run it even if a webserver is not available.
> Moving this test case earlier in the script seems to confirm it, as it
> still succeeds.
It turns out 't5510' is not the only test script that contains
non-httpd-specific tests after sourcing 'lib-httpd.sh', but 't5703'
did so as well.
The first patch is a follow-up to 'sg/t5510-test-i18ngrep-fix'.
The second patch fixes a similar issue from the v2.19 era.
The last one only adds comments to all the other test scripts sourcing
'lib-httpd.sh' to warn against adding non-httpd-specific tests at the
end, in the hope that it won't happen again.
SZEDER Gábor (3):
t5510-fetch: run non-httpd-specific test before sourcing
'lib-httpd.sh'
t5703: run all non-httpd-specific tests before sourcing 'lib-httpd.sh'
tests: warn against appending non-httpd-specific tests at the end
t/t0410-partial-clone.sh | 3 +
t/t5500-fetch-pack.sh | 3 +
t/t5510-fetch.sh | 47 +++----
t/t5537-fetch-shallow.sh | 3 +
t/t5545-push-options.sh | 3 +
t/t5601-clone.sh | 3 +
t/t5616-partial-clone.sh | 3 +
t/t5700-protocol-v1.sh | 3 +
t/t5702-protocol-v2.sh | 3 +
t/t5703-upload-pack-ref-in-want.sh | 204 +++++++++++++++--------------
10 files changed, 153 insertions(+), 122 deletions(-)
--
2.22.0.926.g602b9a0287
next prev parent reply other threads:[~2019-08-01 15:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 20:25 [PATCH 0/3] fetch: add --[no-]show-forced-updates Derrick Stolee via GitGitGadget
2019-06-18 20:25 ` [PATCH 1/3] fetch: add --[no-]show-forced-updates argument Derrick Stolee via GitGitGadget
2019-07-30 21:29 ` [PATCH] t5510-fetch: fix negated 'test_i18ngrep' invocation SZEDER Gábor
2019-07-30 21:40 ` SZEDER Gábor
2019-07-31 10:35 ` Derrick Stolee
2019-08-01 15:53 ` SZEDER Gábor [this message]
2019-08-01 15:53 ` [PATCH 1/3] t5510-fetch: run non-httpd-specific test before sourcing 'lib-httpd.sh' SZEDER Gábor
2019-08-01 17:51 ` Derrick Stolee
2019-08-01 15:53 ` [PATCH 2/3] t5703: run all non-httpd-specific tests " SZEDER Gábor
2019-08-01 15:53 ` [PATCH 3/3] tests: warn against appending non-httpd-specific tests at the end SZEDER Gábor
2019-08-01 17:41 ` SZEDER Gábor
2019-08-01 18:18 ` Junio C Hamano
2019-08-02 10:09 ` SZEDER Gábor
2019-08-02 16:37 ` Junio C Hamano
2019-06-18 20:25 ` [PATCH 2/3] fetch: warn about forced updates in branch listing Derrick Stolee via GitGitGadget
2019-06-18 20:25 ` [PATCH 3/3] pull: add --[no-]show-forced-updates passthrough Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801155309.15276-1-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=bwilliams.eng@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).