git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Todd Zullinger <tmz@pobox.com>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	git-packagers@googlegroups.com
Subject: Re: New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)
Date: Thu, 23 May 2019 15:14:30 -0400	[thread overview]
Message-ID: <20190523191429.GO3654@pobox.com> (raw)
In-Reply-To: <20190523150416.GL3654@pobox.com>

I wrote:
> While running the 2.22.0-rc1 tests on Fedora, I hit a few
> new test failures since 2.21.0 -- but only on the s390x
> architecture.
> 
> I haven't had time to dig into these the past few days, so I
> thought I would send what I do have in case the problem is
> obvious to someone else.  I think all of the failing tests
> are due to `git diff` commands.
[...]
> I don't have direct access to these s390x builders.  I may
> be able to arrange shell access (or even reproduce this with
> qemu's s390x emulation).

I poked around a little with a qemu s390x instance and see
the same failures.

One simple failure in t4015 is with:

    git diff -w >out &&
    test_must_be_empty out

Using git-2.21.0 this succeeds, while git-2.22.0-rc1 fails
and produces:

    diff --git a/x b/x
    index d99af23..22d9f73 100644
    --- a/x
    +++ b/x
    @@ -1,6 +1,6 @@
    -whitespace at beginning
    -whitespace change
    -whitespace in the middle
    -whitespace at end
    + 	whitespace at beginning
    +whitespace 	 change
    +white space in the middle
    +whitespace at end  
     unchanged line
    -CR at end
    +CR at end

I am guessing it's no coincidence that this only fails on
s390x and it is the only big endian architecture in the
fedora build system.

-- 
Todd

  reply	other threads:[~2019-05-23 19:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19  9:04 [ANNOUNCE] Git v2.22.0-rc1 Junio C Hamano
2019-05-19 20:30 ` Johannes Schindelin
2019-05-20 19:06 ` Bryan Turner
2019-05-20 22:27   ` Ævar Arnfjörð Bjarmason
2019-05-21  8:31     ` Duy Nguyen
2019-05-21 10:22       ` Duy Nguyen
2019-05-21 11:24         ` Ævar Arnfjörð Bjarmason
2019-05-21 11:46           ` Duy Nguyen
2019-05-23 15:04 ` New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1) Todd Zullinger
2019-05-23 19:14   ` Todd Zullinger [this message]
2019-05-23 20:30     ` Duy Nguyen
2019-05-23 21:06       ` Todd Zullinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523191429.GO3654@pobox.com \
    --to=tmz@pobox.com \
    --cc=git-packagers@googlegroups.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --subject='Re: New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).