From: Duy Nguyen <email@example.com> To: "Ævar Arnfjörð Bjarmason" <firstname.lastname@example.org> Cc: Bryan Turner <email@example.com>, Junio C Hamano <firstname.lastname@example.org>, Git Users <email@example.com>, Linux Kernel <firstname.lastname@example.org>, email@example.com Subject: Re: [ANNOUNCE] Git v2.22.0-rc1 Date: Tue, 21 May 2019 15:31:52 +0700 [thread overview] Message-ID: <CACsJy8AdhQH25NeDKKdSBctXcU=oyGcJ05XaNryj22GUQH5Btw@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, May 21, 2019 at 5:27 AM Ævar Arnfjörð Bjarmason <email@example.com> wrote: > > > On Mon, May 20 2019, Bryan Turner wrote: > > > On Sun, May 19, 2019 at 10:00 AM Junio C Hamano <firstname.lastname@example.org> wrote: > >> > >> * The diff machinery, one of the oldest parts of the system, which > >> long predates the parse-options API, uses fairly long and complex > >> handcrafted option parser. This is being rewritten to use the > >> parse-options API. > > > > It looks like with these changes it's no longer possible to use "-U" > > (or, I'd assume, "--unified") without adding an explicit number for > > context lines. > > > > ... > > I don't know if argument-less -U was ever intended, but I think in light > of what you're saying we should consider it a regression to fix before > 2.22.0 is out. CC-ing Duy who wrote d473e2e0e8 ("diff.c: convert > -U|--unified", 2019-01-27). There should be no behavior change in this series. Period. I'm pretty sure I misread the old opt_arg() code and this is the result. --inter-hunk-context is also affected. I'm working on it. > The bug there is that the old opt_arg() code would be torelant to empty > values. I noticed a similar change the other day with the --abbrev > option, but didn't think it was worth noting. Maybe it's a more general > problem, in both cases we had a blindspot in our tests. Hmm.. this one is different (at least it does not use opt_arg()). But I'll double check. -- Duy
next prev parent reply other threads:[~2019-05-21 8:32 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-19 9:04 Junio C Hamano 2019-05-19 20:30 ` Johannes Schindelin 2019-05-20 19:06 ` Bryan Turner 2019-05-20 22:27 ` Ævar Arnfjörð Bjarmason 2019-05-21 8:31 ` Duy Nguyen [this message] 2019-05-21 10:22 ` Duy Nguyen 2019-05-21 11:24 ` Ævar Arnfjörð Bjarmason 2019-05-21 11:46 ` Duy Nguyen 2019-05-23 15:04 ` New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1) Todd Zullinger 2019-05-23 19:14 ` Todd Zullinger 2019-05-23 20:30 ` Duy Nguyen 2019-05-23 21:06 ` Todd Zullinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACsJy8AdhQH25NeDKKdSBctXcU=oyGcJ05XaNryj22GUQH5Btw@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [ANNOUNCE] Git v2.22.0-rc1' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).