From: Duy Nguyen <firstname.lastname@example.org> To: "Ævar Arnfjörð Bjarmason" <email@example.com> Cc: Bryan Turner <firstname.lastname@example.org>, Junio C Hamano <email@example.com>, Git Users <firstname.lastname@example.org> Subject: Re: [ANNOUNCE] Git v2.22.0-rc1 Date: Tue, 21 May 2019 17:22:50 +0700 [thread overview] Message-ID: <CACsJy8AU7=N_npgTuLES3r8VBMw+6kS+7D-B5MY0eghdD8O=AQ@mail.gmail.com> (raw) In-Reply-To: <CACsJy8AdhQH25NeDKKdSBctXcU=oyGcJ05XaNryj22GUQH5Btw@mail.gmail.com> (dropping lkml and git-packagers) On Tue, May 21, 2019 at 3:31 PM Duy Nguyen <email@example.com> wrote: > > The bug there is that the old opt_arg() code would be torelant to empty > > values. I noticed a similar change the other day with the --abbrev > > option, but didn't think it was worth noting. Maybe it's a more general > > problem, in both cases we had a blindspot in our tests. > > Hmm.. this one is different (at least it does not use opt_arg()). But > I'll double check. What is wrong with --abbrev? The code is simple enough for me to just compare line by line, and the only difference I can see is that if you pass --abbrev=12a, then the old code accepts "12" while the new one rejects. Granted, I said "no behavior change", but this may be pushing the limits a bit. But maybe you're seeing something else? Note that "git diff --abbrev" still uses the old, but different, parser in revision.c. parse_options() is only used for --abbrev with --no-index. -- Duy
next prev parent reply other threads:[~2019-05-21 10:23 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-19 9:04 Junio C Hamano 2019-05-19 20:30 ` Johannes Schindelin 2019-05-20 19:06 ` Bryan Turner 2019-05-20 22:27 ` Ævar Arnfjörð Bjarmason 2019-05-21 8:31 ` Duy Nguyen 2019-05-21 10:22 ` Duy Nguyen [this message] 2019-05-21 11:24 ` Ævar Arnfjörð Bjarmason 2019-05-21 11:46 ` Duy Nguyen 2019-05-23 15:04 ` New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1) Todd Zullinger 2019-05-23 19:14 ` Todd Zullinger 2019-05-23 20:30 ` Duy Nguyen 2019-05-23 21:06 ` Todd Zullinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACsJy8AU7=N_npgTuLES3r8VBMw+6kS+7D-B5MY0eghdD8O=AQ@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [ANNOUNCE] Git v2.22.0-rc1' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).