From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Haaris Mehmood" <hsed@unimetic.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH] tests: avoid syntax triggering old dash bug
Date: Tue, 27 Nov 2018 17:42:53 +0100 [thread overview]
Message-ID: <20181127164253.9832-1-avarab@gmail.com> (raw)
Avoid a bug in dash that's been fixed ever since its
ec2c84d ("[PARSER] Fix clobbering of checkkwd", 2011-03-15)[1] first
released with dash v0.5.7 in July 2011.
This fixes 1/2 tests failing on Debian Lenny & Squeeze. The other
failure is due to 1b42f45255 ("git-svn: apply "svn.pathnameencoding"
before URL encoding", 2016-02-09).
This particular test has been failing since 5f9674243d ("config: add
--expiry-date", 2017-11-18).
1. https://git.kernel.org/pub/scm/utils/dash/dash.git/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
t/t1300-config.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t1300-config.sh b/t/t1300-config.sh
index 9652b241c7..7690b518b8 100755
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -892,8 +892,9 @@ test_expect_success 'get --expiry-date' '
1510348087
0
EOF
+ date_valid1=$(git config --expiry-date date.valid1) &&
{
- echo "$rel_out $(git config --expiry-date date.valid1)"
+ echo "$rel_out $date_valid1"
git config --expiry-date date.valid2 &&
git config --expiry-date date.valid3 &&
git config --expiry-date date.valid4 &&
--
2.20.0.rc1.379.g1dd7ef354c
next reply other threads:[~2018-11-27 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:42 Ævar Arnfjörð Bjarmason [this message]
2018-11-27 19:16 ` [PATCH] tests: avoid syntax triggering old dash bug Eric Sunshine
2018-11-27 19:37 ` Ævar Arnfjörð Bjarmason
2018-11-28 4:45 ` Junio C Hamano
2019-02-13 11:59 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-02-13 21:43 ` Junio C Hamano
2019-02-13 21:48 ` SZEDER Gábor
2019-02-14 9:51 ` Ævar Arnfjörð Bjarmason
2018-11-28 1:47 ` [PATCH] " brian m. carlson
2018-11-28 7:06 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127164253.9832-1-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hsed@unimetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).