From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
hsed@unimetic.com
Subject: Re: [PATCH v2] tests: avoid syntax triggering old dash bug
Date: Wed, 13 Feb 2019 13:43:28 -0800 [thread overview]
Message-ID: <xmqqd0nvbbzz.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190213115951.12096-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 13 Feb 2019 12:59:51 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Avoid a bug in dash that's been fixed ever since its
> ec2c84d ("[PARSER] Fix clobbering of checkkwd", 2011-03-15)[1] first
> released with dash v0.5.7 in July 2011. This failing test was
> introduced in 5f9674243d ("config: add --expiry-date", 2017-11-18).
Thanks for not forgetting an year-old topic. The offending commit
predates 2.16.0 that is a while ago ;-)
> This isn't a 2.21 regression, but sending it in the rc window anyway
> in case you'd like to queue an obviously working minor portability
> fix.
>
> t/t1300-config.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t/t1300-config.sh b/t/t1300-config.sh
> index 9652b241c7..428177c390 100755
> --- a/t/t1300-config.sh
> +++ b/t/t1300-config.sh
> @@ -892,6 +892,7 @@ test_expect_success 'get --expiry-date' '
> 1510348087
> 0
> EOF
> + : "work around heredoc parsing bug fixed in dash 0.5.7 (in ec2c84d)" &&
> {
> echo "$rel_out $(git config --expiry-date date.valid1)"
> git config --expiry-date date.valid2 &&
next prev parent reply other threads:[~2019-02-13 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:42 [PATCH] tests: avoid syntax triggering old dash bug Ævar Arnfjörð Bjarmason
2018-11-27 19:16 ` Eric Sunshine
2018-11-27 19:37 ` Ævar Arnfjörð Bjarmason
2018-11-28 4:45 ` Junio C Hamano
2019-02-13 11:59 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-02-13 21:43 ` Junio C Hamano [this message]
2019-02-13 21:48 ` SZEDER Gábor
2019-02-14 9:51 ` Ævar Arnfjörð Bjarmason
2018-11-28 1:47 ` [PATCH] " brian m. carlson
2018-11-28 7:06 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0nvbbzz.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hsed@unimetic.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).