list mirror (unofficial, one of many)
 help / color / Atom feed
From: Ævar Arnfjörð Bjarmason <>
To: SZEDER Gábor <>
Cc:, Junio C Hamano <>,
	Eric Sunshine <>,
Subject: Re: [PATCH v2] tests: avoid syntax triggering old dash bug
Date: Thu, 14 Feb 2019 10:51:03 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 13 2019, SZEDER Gábor wrote:

> On Wed, Feb 13, 2019 at 12:59:51PM +0100, Ævar Arnfjörð Bjarmason wrote:
>> Avoid a bug in dash that's been fixed ever since its
>> ec2c84d ("[PARSER] Fix clobbering of checkkwd", 2011-03-15)[1] first
>> released with dash v0.5.7 in July 2011. This failing test was
>> introduced in 5f9674243d ("config: add --expiry-date", 2017-11-18).
>> This fixes 1/2 tests failing on Debian Lenny & Squeeze. The other
> Do I understand this "1/2" right?  There are two tests failing on
> Lenny and Squeeze, and this fixes one of those bugs?

Yeah, so there's one bug left now, which I haven't tracked down.

>> failure is due to 1b42f45255 ("git-svn: apply "svn.pathnameencoding"
>> before URL encoding", 2016-02-09).
>> The dash bug is triggered by this test because the heredoc contains a
>> command embedded in "$()" with a "{}" block coming right after
>> it. Refactoring the "$()" to e.g. be a variable that was set earlier
>> will also work around it, but let's instead break up the "EOF" and the
>> "{}".
>> An earlier version of this patch[2] mitigated the issue by breaking
>> the "$()" out of the "{}" block, that worked, but just because it
>> broke up the "EOF" and "{}" block. Putting e.g. "echo &&" between the
>> two would also work.
>> 1.
> Could you please link directly to the commit fixing that issue?

Should have done that, but I'll hold off on a re-roll for such a minor
cosmetic issue since I see Junio's merged it down to "next" already. The
dash.git hash is noted in the commit message, so it's not a practical
problem to find the commit, but yeah, would be nice if were a clickable

>> 2.
>> Signed-off-by: Ævar Arnfjörð Bjarmason <>

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27 16:42 [PATCH] " Ævar Arnfjörð Bjarmason
2018-11-27 19:16 ` Eric Sunshine
2018-11-27 19:37   ` Ævar Arnfjörð Bjarmason
2018-11-28  4:45   ` Junio C Hamano
2019-02-13 11:59     ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2019-02-13 21:43       ` Junio C Hamano
2019-02-13 21:48       ` SZEDER Gábor
2019-02-14  9:51         ` Ævar Arnfjörð Bjarmason [this message]
2018-11-28  1:47 ` [PATCH] " brian m. carlson
2018-11-28  7:06   ` Torsten Bögershausen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone