From: Jeff King <peff@peff.net>
To: Daniels Umanovskis <daniels@umanovskis.se>
Cc: "Rafael Ascensão" <rafa.almas@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] branch: introduce --show-current display option
Date: Thu, 11 Oct 2018 13:51:36 -0400 [thread overview]
Message-ID: <20181011175136.GA8825@sigill.intra.peff.net> (raw)
In-Reply-To: <1409ebd2-d72c-fbd6-bf5c-777342723ca2@umanovskis.se>
On Thu, Oct 11, 2018 at 06:36:02PM +0200, Daniels Umanovskis wrote:
> On 10/11/18 5:43 PM, Rafael Ascensão wrote:
> > I agree it feels a bit out of place, and still think that
> >
> > $ git branch --list HEAD
> >
> > would be a good candidate to be taught how to print the current branch.
>
> I am not a fan because it would be yet another inconsistency in the Git
> command interface. An argument given after git branch --list means a
> pattern for the branches to list. Making HEAD print the current branch
> would be an exception to what an argument in that place means. Yes, HEAD
> itself is a very special string in git, but I'm not a fan of syntax
> where a specific argument value does something very different from any
> other value in that place.
Yeah, I agree. If we were to go this route, it should probably be:
git branch --list-head
Which sounds a lot like what you are proposing, but I think the name
implies more strongly "show --list, but only for the HEAD". I.e., for
the detached case, show the "HEAD detached at..." text.
-Peff
next prev parent reply other threads:[~2018-10-11 17:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:54 [PATCH v2 0/1] branch: introduce --show-current display option Daniels Umanovskis
2018-10-10 20:54 ` [PATCH v2 1/1] " Daniels Umanovskis
2018-10-11 0:34 ` Jeff King
2018-10-11 15:43 ` Rafael Ascensão
2018-10-11 16:36 ` Daniels Umanovskis
2018-10-11 17:51 ` Jeff King [this message]
2018-10-11 20:35 ` Rafael Ascensão
2018-10-11 20:46 ` Daniels Umanovskis
2018-10-11 20:53 ` Jeff King
2018-10-11 22:34 ` Rafael Ascensão
2018-10-11 6:54 ` Junio C Hamano
2018-10-11 17:29 ` Daniels Umanovskis
2018-10-11 17:52 ` Jeff King
2018-10-11 22:20 ` [PATCH v3] " Daniels Umanovskis
2018-10-11 23:15 ` Junio C Hamano
2018-10-11 23:31 ` Daniels Umanovskis
2018-10-12 13:33 ` [PATCH v4] " Daniels Umanovskis
2018-10-12 13:43 ` Eric Sunshine
2018-10-16 23:09 ` Junio C Hamano
2018-10-16 23:26 ` Eric Sunshine
2018-10-17 10:18 ` Johannes Schindelin
2018-10-17 10:39 ` Eric Sunshine
2018-10-18 9:51 ` Johannes Schindelin
2018-10-18 14:19 ` Eric Sunshine
2018-10-16 5:59 ` Junio C Hamano
2018-10-17 9:39 ` Rafael Ascensão
2018-10-17 17:36 ` Daniels Umanovskis
2018-10-11 22:53 ` [PATCH v2 1/1] " SZEDER Gábor
2018-10-11 22:56 ` SZEDER Gábor
2018-10-11 22:58 ` Daniels Umanovskis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011175136.GA8825@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=daniels@umanovskis.se \
--cc=git@vger.kernel.org \
--cc=rafa.almas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).