From: Jeff King <peff@peff.net>
To: "Rafael Ascensão" <rafa.almas@gmail.com>
Cc: Daniels Umanovskis <daniels@umanovskis.se>, git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] branch: introduce --show-current display option
Date: Thu, 11 Oct 2018 16:53:23 -0400 [thread overview]
Message-ID: <20181011205323.GB11618@sigill.intra.peff.net> (raw)
In-Reply-To: <20181011203518.GA2385@rigel>
On Thu, Oct 11, 2018 at 09:35:28PM +0100, Rafael Ascensão wrote:
> On Thu, Oct 11, 2018 at 01:51:36PM -0400, Jeff King wrote:
> > Yeah, I agree.
>
> Not sure which parts you meant, so I'll assume you didn't agree
> with me.
Correct. ;)
I like your general idea, but I agree with Daniel that it introduces an
inconsistency in the interface.
> I doesn't seem far fetched to ask for an overview of my current branch,
> feature1, feature2 and all hotfixes with something like:
>
> $ git branch --verbose --list HEAD feature1 feature2 hotfix-*;
>
> The 'what's my current branch' could be just a particular case of this
> form.
Right, I like that part. It's just that putting "HEAD" there already has
a meaning: it would find refs/heads/HEAD.
Now I'll grant that's a bad name for a branch (and the source of other
confusions, and I think perhaps even something a few commands actively
discourage these days).
> My defense to treat HEAD specially comes in the form that from the user
> perspective, HEAD is already being resolved to a commit when HEAD is
> detached (Showing the detached at <hash> message.)
>
> Is there a strong reason to *not* "resolve" HEAD when it is attached?
> Would it be that bad to have some DWIM behaviour here? After all, as
> HEAD is an invalid name for a branch, nothing would ever match it
> anyways.
I don't think this is about resolving HEAD, or showing it. It's about
the fact that arguments to "branch" are currently always branch-names,
not full refs.
-Peff
next prev parent reply other threads:[~2018-10-11 20:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:54 [PATCH v2 0/1] branch: introduce --show-current display option Daniels Umanovskis
2018-10-10 20:54 ` [PATCH v2 1/1] " Daniels Umanovskis
2018-10-11 0:34 ` Jeff King
2018-10-11 15:43 ` Rafael Ascensão
2018-10-11 16:36 ` Daniels Umanovskis
2018-10-11 17:51 ` Jeff King
2018-10-11 20:35 ` Rafael Ascensão
2018-10-11 20:46 ` Daniels Umanovskis
2018-10-11 20:53 ` Jeff King [this message]
2018-10-11 22:34 ` Rafael Ascensão
2018-10-11 6:54 ` Junio C Hamano
2018-10-11 17:29 ` Daniels Umanovskis
2018-10-11 17:52 ` Jeff King
2018-10-11 22:20 ` [PATCH v3] " Daniels Umanovskis
2018-10-11 23:15 ` Junio C Hamano
2018-10-11 23:31 ` Daniels Umanovskis
2018-10-12 13:33 ` [PATCH v4] " Daniels Umanovskis
2018-10-12 13:43 ` Eric Sunshine
2018-10-16 23:09 ` Junio C Hamano
2018-10-16 23:26 ` Eric Sunshine
2018-10-17 10:18 ` Johannes Schindelin
2018-10-17 10:39 ` Eric Sunshine
2018-10-18 9:51 ` Johannes Schindelin
2018-10-18 14:19 ` Eric Sunshine
2018-10-16 5:59 ` Junio C Hamano
2018-10-17 9:39 ` Rafael Ascensão
2018-10-17 17:36 ` Daniels Umanovskis
2018-10-11 22:53 ` [PATCH v2 1/1] " SZEDER Gábor
2018-10-11 22:56 ` SZEDER Gábor
2018-10-11 22:58 ` Daniels Umanovskis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011205323.GB11618@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=daniels@umanovskis.se \
--cc=git@vger.kernel.org \
--cc=rafa.almas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).