From: Daniels Umanovskis <daniels@umanovskis.se>
To: git@vger.kernel.org
Cc: Daniels Umanovskis <daniels@umanovskis.se>
Subject: [PATCH v2 0/1] branch: introduce --show-current display option
Date: Wed, 10 Oct 2018 22:54:31 +0200 [thread overview]
Message-ID: <20181010205432.11990-1-daniels@umanovskis.se> (raw)
v2 reroll of a previously-discussed patch. Thanks to everyone for their
comments. Based on feedback:
1. Command is now a verb: git branch --show-current.
2. Changed to gitster's suggested implementation: nothing is printed
if HEAD does not point to a symbolic ref. A fatal
error if HEAD is a symbolic ref but does not start with refs/heads/.
3. Added a test to show this works with worktrees
A process question to the list. The patch adds a new localizable string
that gets output in case of repository corruption. I happen to speak a
couple of the languages that have po files. Is it accepted practice to
also include po edits in my patch in such a case, or should that be
left to the regular l10n workflow?
Daniels Umanovskis (1):
branch: introduce --show-current display option
Documentation/git-branch.txt | 6 +++++-
builtin/branch.c | 21 ++++++++++++++++--
t/t3203-branch-output.sh | 41 ++++++++++++++++++++++++++++++++++++
3 files changed, 65 insertions(+), 3 deletions(-)
--
2.19.1.330.g93276587c.dirty
next reply other threads:[~2018-10-10 20:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:54 Daniels Umanovskis [this message]
2018-10-10 20:54 ` [PATCH v2 1/1] branch: introduce --show-current display option Daniels Umanovskis
2018-10-11 0:34 ` Jeff King
2018-10-11 15:43 ` Rafael Ascensão
2018-10-11 16:36 ` Daniels Umanovskis
2018-10-11 17:51 ` Jeff King
2018-10-11 20:35 ` Rafael Ascensão
2018-10-11 20:46 ` Daniels Umanovskis
2018-10-11 20:53 ` Jeff King
2018-10-11 22:34 ` Rafael Ascensão
2018-10-11 6:54 ` Junio C Hamano
2018-10-11 17:29 ` Daniels Umanovskis
2018-10-11 17:52 ` Jeff King
2018-10-11 22:20 ` [PATCH v3] " Daniels Umanovskis
2018-10-11 23:15 ` Junio C Hamano
2018-10-11 23:31 ` Daniels Umanovskis
2018-10-12 13:33 ` [PATCH v4] " Daniels Umanovskis
2018-10-12 13:43 ` Eric Sunshine
2018-10-16 23:09 ` Junio C Hamano
2018-10-16 23:26 ` Eric Sunshine
2018-10-17 10:18 ` Johannes Schindelin
2018-10-17 10:39 ` Eric Sunshine
2018-10-18 9:51 ` Johannes Schindelin
2018-10-18 14:19 ` Eric Sunshine
2018-10-16 5:59 ` Junio C Hamano
2018-10-17 9:39 ` Rafael Ascensão
2018-10-17 17:36 ` Daniels Umanovskis
2018-10-11 22:53 ` [PATCH v2 1/1] " SZEDER Gábor
2018-10-11 22:56 ` SZEDER Gábor
2018-10-11 22:58 ` Daniels Umanovskis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010205432.11990-1-daniels@umanovskis.se \
--to=daniels@umanovskis.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).