git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] mailmap: consistently normalize brian m. carlson's name
Date: Mon, 24 Sep 2018 19:13:20 -0700	[thread overview]
Message-ID: <20180925021320.GQ138072@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180925011547.GG432229@genre.crustytoothpaste.net>

brian m. carlson wrote:
> On Mon, Sep 24, 2018 at 10:39:02AM -0700, Jonathan Nieder wrote:
>> brian m. carlson wrote:

>>> I think this commit message makes sense.
[...]
>>                              What would it take to make the patch make
>> sense, too? ;-)
>
> I certainly didn't mean to imply a failing on your part for explaining
> the change adequately.  I've just always found the format confusing and
> I know others do, too.

No worries.  I took the opportunity because the patch isn't in "next"
yet so I was looking for a way to nudge it forward.  I think v2 is
simpler than v1.  Thanks for your help.

[...]
> This has been a really helpful explanation.  Thanks.
>
> Maybe I'll have some time over the next week or so to send a patch to
> the documentation to make it more understandable to past me.

Sounds good.  I think the (non-)handling of the 'name <email> name'
case is likely to be a bug.

>> How about this?
[...]
> Having read your explanation, this looks good.  Thanks for fixing this.

\o/ Thanks for looking it over.

Sincerely,
Jonathan

      reply	other threads:[~2018-09-25  2:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-06 23:24 [PATCH] mailmap: update brian m. carlson's email address brian m. carlson
2018-05-07  3:37 ` Junio C Hamano
2018-05-07 19:25   ` Stefan Beller
2018-05-07 23:53     ` brian m. carlson
2018-05-07 23:44   ` brian m. carlson
2018-05-08  1:58 ` [PATCH v2] " brian m. carlson
2018-05-08  3:21   ` Junio C Hamano
2018-05-08  5:04   ` Kaartic Sivaraam
2018-05-09  0:19     ` brian m. carlson
2018-05-09  7:03       ` Kaartic Sivaraam
2018-05-10 23:13         ` brian m. carlson
2018-05-22 22:08   ` Jonathan Nieder
2018-05-22 22:42     ` brian m. carlson
2018-09-17 18:18       ` [PATCH] mailmap: consistently normalize brian m. carlson's name Jonathan Nieder
2018-09-17 22:21         ` brian m. carlson
2018-09-24 17:39           ` [PATCH v2] " Jonathan Nieder
2018-09-25  1:15             ` brian m. carlson
2018-09-25  2:13               ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925021320.GQ138072@aiede.svl.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).