From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] mailmap: consistently normalize brian m. carlson's name
Date: Tue, 25 Sep 2018 01:15:47 +0000 [thread overview]
Message-ID: <20180925011547.GG432229@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20180924173902.GB138072@aiede.svl.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 3149 bytes --]
On Mon, Sep 24, 2018 at 10:39:02AM -0700, Jonathan Nieder wrote:
> Hi,
>
> brian m. carlson wrote:
>
> > I think this commit message makes sense. I apparently still fail to
> > understand how the .mailmap format works, so I can't tell you if the
> > patch is correct.
>
> Thanks for looking it over. What would it take to make the patch make
> sense, too? ;-)
I certainly didn't mean to imply a failing on your part for explaining
the change adequately. I've just always found the format confusing and
I know others do, too.
> Most mailmap entries are of the form
>
> Some Name <someemail@example.com>
>
> which means "Wherever you see the email address someemail@example.com,
> canonicalize the author's name to Some Name". We can use that:
>
> brian m. carlson <sandals@crustytoothpaste.net>
>
> When we see sandals@crustytoothpaste.ath.cx, we also want to
> canonicalize the email address. For that, we can do
>
> brian m. carlson <sandals@crustytoothpaste.net> <sandals@crustytoothpaste.ath.cx>
>
> There's only one person who has used these email addresses, so we
> don't have to do matching by name. If we wanted to tighten the name
> normalization to match by name, I think we'd do something like
>
> brian m. carlson <sandals@crustytoothpaste.net> Brian M. Carlson
>
> but I can't get that to seem to have any effect when I test with the
> "git check-mailmap" command --- for example, "git check-mailmap 'Dana
> How <random.email@example.com>'" does not map and "git check-mailmap
> 'Random Name <danahow@gmail.com>'" maps to 'Dana L. How
> <danahow@gmail.com>'.
>
> The even tighter matching used in v1
>
> brian m. carlson <sandals@crustytoothpaste.net> Brian M. Carlson <sandals@crustytoothpaste.net>
>
> does work, but it's unnecessary complexity. We don't need it.
This has been a really helpful explanation. Thanks.
Maybe I'll have some time over the next week or so to send a patch to
the documentation to make it more understandable to past me.
> How about this?
>
> Changes since v1:
> - loosened the matching to only look at email and ignore name
> - no other changes
>
> .mailmap | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.mailmap b/.mailmap
> index f165222a78..bef3352b0d 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -25,7 +25,7 @@ Ben Walton <bdwalton@gmail.com> <bwalton@artsci.utoronto.ca>
> Benoit Sigoure <tsunanet@gmail.com> <tsuna@lrde.epita.fr>
> Bernt Hansen <bernt@norang.ca> <bernt@alumni.uwaterloo.ca>
> Brandon Casey <drafnel@gmail.com> <casey@nrlssc.navy.mil>
> -brian m. carlson <sandals@crustytoothpaste.net> Brian M. Carlson <sandals@crustytoothpaste.ath.cx>
> +brian m. carlson <sandals@crustytoothpaste.net>
> brian m. carlson <sandals@crustytoothpaste.net> <sandals@crustytoothpaste.ath.cx>
> Bryan Larsen <bryan@larsen.st> <bryan.larsen@gmail.com>
> Bryan Larsen <bryan@larsen.st> <bryanlarsen@yahoo.com>
Having read your explanation, this looks good. Thanks for fixing this.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2018-09-25 1:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 23:24 [PATCH] mailmap: update brian m. carlson's email address brian m. carlson
2018-05-07 3:37 ` Junio C Hamano
2018-05-07 19:25 ` Stefan Beller
2018-05-07 23:53 ` brian m. carlson
2018-05-07 23:44 ` brian m. carlson
2018-05-08 1:58 ` [PATCH v2] " brian m. carlson
2018-05-08 3:21 ` Junio C Hamano
2018-05-08 5:04 ` Kaartic Sivaraam
2018-05-09 0:19 ` brian m. carlson
2018-05-09 7:03 ` Kaartic Sivaraam
2018-05-10 23:13 ` brian m. carlson
2018-05-22 22:08 ` Jonathan Nieder
2018-05-22 22:42 ` brian m. carlson
2018-09-17 18:18 ` [PATCH] mailmap: consistently normalize brian m. carlson's name Jonathan Nieder
2018-09-17 22:21 ` brian m. carlson
2018-09-24 17:39 ` [PATCH v2] " Jonathan Nieder
2018-09-25 1:15 ` brian m. carlson [this message]
2018-09-25 2:13 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925011547.GG432229@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).