From: Jonathan Nieder <jrnieder@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] mailmap: update brian m. carlson's email address
Date: Tue, 22 May 2018 15:08:26 -0700 [thread overview]
Message-ID: <20180522220826.GP10623@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180508015845.268572-1-sandals@crustytoothpaste.net>
Hi,
brian m. carlson wrote:
> An earlier change, cdb6b5ac (".mailmap: Combine more (name, email) to
> individual persons", 2013-08-12), noted that there were two name
> spellings and two email addresses and mapped the crustytoothpaste.net
> address to the crustytoothpaste.ath.cx address. The latter is an older,
> obsolete address, while the former is current, so switch the order of
> the addresses so that git log displays the correct address.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> I intentionally avoided the use of the first person here, because I
> wasn't sure what the preference of the list was on that. Hopefully it
> reads naturally and isn't awkward.
I have no preference. First or third person would work equally well
for me for this kind of thing.
[...]
> --- a/.mailmap
> +++ b/.mailmap
> @@ -25,8 +25,8 @@ Ben Walton <bdwalton@gmail.com> <bwalton@artsci.utoronto.ca>
> Benoit Sigoure <tsunanet@gmail.com> <tsuna@lrde.epita.fr>
> Bernt Hansen <bernt@norang.ca> <bernt@alumni.uwaterloo.ca>
> Brandon Casey <drafnel@gmail.com> <casey@nrlssc.navy.mil>
> -brian m. carlson <sandals@crustytoothpaste.ath.cx> Brian M. Carlson <sandals@crustytoothpaste.ath.cx>
> -brian m. carlson <sandals@crustytoothpaste.ath.cx> <sandals@crustytoothpaste.net>
> +brian m. carlson <sandals@crustytoothpaste.net> Brian M. Carlson <sandals@crustytoothpaste.ath.cx>
> +brian m. carlson <sandals@crustytoothpaste.net> <sandals@crustytoothpaste.ath.cx>
Today I tried a "git shortlog" run and was surprised to find
Brian M. Carlson (6):
Add missing test file for UTF-16.
submodule: fix confusing variable name
submodule: don't print status output with ignore=all
send-email: don't call methods on undefined values
http-backend: provide Allow header for 405
remote-curl: fix large pushes with GSSAPI
These commits use author Brian M. Carlson <sandals@crustytoothpaste.net>.
Previously they matched
brian m. carlson <sandals@crustytoothpaste.ath.cx> <sandals@crustytoothpaste.net>
but now they don't match any line in the .mailmap file.
Should we add a line
brian m. carlson <sandals@crustytoothpaste.net>
to handle these commits?
Thanks,
Jonathan
next prev parent reply other threads:[~2018-05-22 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 23:24 [PATCH] mailmap: update brian m. carlson's email address brian m. carlson
2018-05-07 3:37 ` Junio C Hamano
2018-05-07 19:25 ` Stefan Beller
2018-05-07 23:53 ` brian m. carlson
2018-05-07 23:44 ` brian m. carlson
2018-05-08 1:58 ` [PATCH v2] " brian m. carlson
2018-05-08 3:21 ` Junio C Hamano
2018-05-08 5:04 ` Kaartic Sivaraam
2018-05-09 0:19 ` brian m. carlson
2018-05-09 7:03 ` Kaartic Sivaraam
2018-05-10 23:13 ` brian m. carlson
2018-05-22 22:08 ` Jonathan Nieder [this message]
2018-05-22 22:42 ` brian m. carlson
2018-09-17 18:18 ` [PATCH] mailmap: consistently normalize brian m. carlson's name Jonathan Nieder
2018-09-17 22:21 ` brian m. carlson
2018-09-24 17:39 ` [PATCH v2] " Jonathan Nieder
2018-09-25 1:15 ` brian m. carlson
2018-09-25 2:13 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522220826.GP10623@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).