From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: wchargin@gmail.com, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] sha1-name.c: for ":/", find detached HEAD commits
Date: Wed, 11 Jul 2018 12:40:41 -0400 [thread overview]
Message-ID: <20180711164041.GB20988@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8CBJvpKAAtVjrdcuO06WossxcMmqwmSRL9Shr7g+qVySA@mail.gmail.com>
On Wed, Jul 11, 2018 at 05:45:09PM +0200, Duy Nguyen wrote:
> > diff --git a/sha1-name.c b/sha1-name.c
> > index 60d9ef3c7..641ca12f9 100644
> > --- a/sha1-name.c
> > +++ b/sha1-name.c
> > @@ -1650,6 +1650,7 @@ static int get_oid_with_context_1(const char *name,
> > struct commit_list *list = NULL;
> >
> > for_each_ref(handle_one_ref, &list);
> > + head_ref(handle_one_ref, &list);
>
> When multiple worktrees are used, should we consider all HEADs or just
> current worktree's HEAD?
>
> This is the latter case, if we should go with the former (I don't
> know, it's a genuine question) then you need one more call:
> other_head_refs().
Oof, I didn't even think about other worktrees. I'd probably say "yes",
as we consider them reachable (and really the intent of this feature
seems to be "find it in any reachable commit").
-Peff
next prev parent reply other threads:[~2018-07-11 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:41 [PATCH] sha1-name.c: for ":/", find detached HEAD commits William Chargin
2018-07-10 17:54 ` Jeff King
2018-07-10 19:06 ` Junio C Hamano
2018-07-11 6:18 ` William Chargin
2018-07-11 12:32 ` Jeff King
2018-07-11 16:34 ` Junio C Hamano
2018-07-11 15:45 ` Duy Nguyen
2018-07-11 16:40 ` Jeff King [this message]
2018-07-11 17:20 ` Junio C Hamano
2018-07-11 17:37 ` Duy Nguyen
2018-07-11 17:49 ` William Chargin
2018-07-12 5:49 ` [PATCH v2] " William Chargin
2018-07-12 15:49 ` Jeff King
2018-07-12 16:04 ` Junio C Hamano
2018-07-12 16:14 ` William Chargin
2018-07-12 19:09 ` Junio C Hamano
2018-07-12 20:01 ` William Chargin
2018-07-13 19:24 ` Jeff King
2018-07-13 19:40 ` William Chargin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711164041.GB20988@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=wchargin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).