git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: William Chargin <wchargin@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Duy Nguyen <pclouds@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] sha1-name.c: for ":/", find detached HEAD commits
Date: Thu, 12 Jul 2018 13:01:23 -0700	[thread overview]
Message-ID: <CAFW+GMByLBbj6oDu-ERhN-bFO__Tj_M752-OYLYa7=z5DF0Ckg@mail.gmail.com> (raw)
In-Reply-To: <xmqqva9kw9ru.fsf@gitster-ct.c.googlers.com>

Contents look good to me. I don't understand why the file name in your
patch is sha1_name.c as opposed to sha1-name.c (I see e5e5e0883 from
2018-04-10, but that sounds pretty old), but I trust that whatever
you're doing there is correct.

> Thanks for working on this.

You're quite welcome. Thanks to you, Peff, and Duy for your help. This
was a pleasant experience for me as a new contributor. :-)

  reply	other threads:[~2018-07-12 20:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 15:41 [PATCH] sha1-name.c: for ":/", find detached HEAD commits William Chargin
2018-07-10 17:54 ` Jeff King
2018-07-10 19:06 ` Junio C Hamano
2018-07-11  6:18   ` William Chargin
2018-07-11 12:32     ` Jeff King
2018-07-11 16:34       ` Junio C Hamano
2018-07-11 15:45 ` Duy Nguyen
2018-07-11 16:40   ` Jeff King
2018-07-11 17:20   ` Junio C Hamano
2018-07-11 17:37     ` Duy Nguyen
2018-07-11 17:49       ` William Chargin
2018-07-12  5:49         ` [PATCH v2] " William Chargin
2018-07-12 15:49           ` Jeff King
2018-07-12 16:04           ` Junio C Hamano
2018-07-12 16:14             ` William Chargin
2018-07-12 19:09               ` Junio C Hamano
2018-07-12 20:01                 ` William Chargin [this message]
2018-07-13 19:24                   ` Jeff King
2018-07-13 19:40                     ` William Chargin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFW+GMByLBbj6oDu-ERhN-bFO__Tj_M752-OYLYa7=z5DF0Ckg@mail.gmail.com' \
    --to=wchargin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).